Fix GetCallerBaggagePairs: resolve userId across all channels#86
Merged
Conversation
userId was only set from AadObjectId, which is null on non-Teams channels and A2A calls. Add fallback chain: AadObjectId → AgenticUserId → From.Id Port of microsoft/Agent365-dotnet#246 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fpfp100
requested review from
TaoChenOSU,
alexlu4250,
harsimar,
juliomenendez,
nikhilNava,
rads-1996,
rajkumar-rangaraj and
xiang17
as code owners
May 5, 2026 00:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent365 hosting telemetry extraction logic so user.id baggage is resolved across more channel types (non-Teams and A2A), and adds unit tests to validate the intended precedence/fallback behavior.
Changes:
- Updated
TurnContextExtensions.GetCallerBaggagePairs()to fall back fromAadObjectId→AgenticUserId→From.Idforuser.id. - Added new MSTest coverage for the
user.idprecedence and fallback scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Microsoft.OpenTelemetry/Agent365/Hosting/Extensions/TurnContextExtensions.cs |
Adds the fallback chain for caller user.id baggage extraction. |
test/Microsoft.OpenTelemetry.Agent365.Tests/Hosting/Extensions/TurnContextExtensionsTests.cs |
Introduces tests validating user.id precedence and fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… #246 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
juliomenendez
approved these changes
May 5, 2026
2 tasks
fpfp100
added a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AadObjectId, which isnullon non-Teams channels and A2A callsAadObjectId → AgenticUserId → From.IdChannel behavior after fix
Test plan
🤖 Generated with Claude Code