Revert: Fix GetCallerBaggagePairs userId fallback#96
Merged
Conversation
fpfp100
requested review from
TaoChenOSU,
alexlu4250,
harsimar,
juliomenendez,
nikhilNava,
rads-1996,
rajkumar-rangaraj and
xiang17
as code owners
May 13, 2026 21:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the caller user.id fallback behavior introduced in #86 so Agent365 telemetry uses only AadObjectId for user.id, aligning with downstream GUID expectations.
Changes:
- Restores
GetCallerBaggagePairsto emituser.idonly fromActivity.From.AadObjectId. - Removes the tests that validated fallback behavior through
AgenticUserIdandFrom.Id.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Microsoft.OpenTelemetry/Agent365/Hosting/Extensions/TurnContextExtensions.cs |
Reverts caller user ID extraction to AadObjectId-only behavior. |
test/Microsoft.OpenTelemetry.Agent365.Tests/Hosting/Extensions/TurnContextExtensionsTests.cs |
Deletes fallback-related tests added for the reverted behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rajkumar-rangaraj
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #86.
The ingest service only accepts GUIDs for
user.id. Any non-GUID value gets replaced with an all-zeros GUID (00000000-0000-0000-0000-000000000000). Allowing non-GUID values as userId (via theAadObjectId → AgenticUserId → From.Idfallback chain) breaks downstream scenarios that expect an AAD object ID.Test plan
🤖 Generated with Claude Code
Note
The original PR will not take effect since UPN (non-GUID) values are always ignored by the ingestion service.