Add publishing support for fedora 41 #4683
Conversation
|
@ami-GS can you please review this? |
.azure/OneBranch.Publish.yml
Outdated
| @@ -80,6 +80,7 @@ parameters: | |||
| - name: RPM | |||
| destionations: | |||
There was a problem hiding this comment.
Looks like there is a typo here destionations -> destination?
There was a problem hiding this comment.
If there is, it's been there for a while. Fedora 40 has been published, so i assumed what's there works. I didn't touch that line. Just duplicated the 40 line and tweaked it a bit to say 41.
There was a problem hiding this comment.
Also, the DEB section uses the same wording just a few lines away
There was a problem hiding this comment.
PR updated with the requested fix, though as before, I can't prove it works
…/msquic into Publish-support-for-fedora-41
|
@microsoft-github-policy-service agree |
| @@ -27,7 +27,7 @@ parameters: | |||
| type: object | |||
| default: | |||
| - name: RPM | |||
| destinations: | |||
| destination: | |||
There was a problem hiding this comment.
These need to be destinations with the s. that's what is used down below.
There was a problem hiding this comment.
I'm afraid we're not communicating very well. The instructions above were to turn it from destionations to destination, There is a typo in what was there earlier, the extra o someone left in there, but the fix suggested was to strip off the s at the end. I didn't even see the o, just the removal of the s. My comment that they were all like that (plural) coupled with your 'can you fix them all' comment made me think you wanted it to just say destination (singular) everywhere. In any event, now that I've caught up, proper fix inbound.
Description
Modify the
OneBranch.publishfile to include fedora 41References issue #4682
Testing
I can't invoke your publish process, which is what this changed, so I can't really test it.
Documentation
Not that I can find.