Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 41 packages not being built or released #4682

Open
sillyotter opened this issue Dec 4, 2024 · 3 comments
Open

Fedora 41 packages not being built or released #4682

sillyotter opened this issue Dec 4, 2024 · 3 comments
Labels
Area: Packaging external Proposed by non-MSFT feature request A request for new functionality OS: Ubuntu
Milestone

Comments

@sillyotter
Copy link
Contributor

Describe the feature you'd like supported

A year ago I opened an issue (#4092) and submitted PR (#4095) to get Fedora 39 packages of msquic released. I have looked but haven't seen any incoming PR's to add Fedora 41 to the list, so I thought I might submit my own again. Apologies if someone else is already fixing this. I'll submit the PR just as soon as I submit the issue.

Proposed solution

Modify .azure/OneBranch.Publish.yml to include Fedora 41

Additional context

No response

@sillyotter sillyotter added the feature request A request for new functionality label Dec 4, 2024
@sillyotter
Copy link
Contributor Author

PR #4683 has the fix

@sillyotter
Copy link
Contributor Author

We got some really bad miscommunications in the original PR. I ended up commiting a bunch of incorrect changes so I deleted it and started over. The new fix is in #4686

Initially, someone pointed out there was a typo in the change I submitted. There was, but there was also a typo in the suggested change. "destionations" was wrong, but the correction, at least what I saw, was to make it a singular "destination". I didn't even seen the o was wrong, just that the suggested fix was to make it singular. I pointed out that the plural was used everywhere else and was suggested I could fix them all, so I did. But, once we all got on the same page, I fixed it correctly. One additional fedora 41 line and a fix to the destionations typo in the containing block.

@nibanks
Copy link
Member

nibanks commented Dec 4, 2024

Thank you so much for working through this with us!

@nibanks nibanks added this to the Future milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Packaging external Proposed by non-MSFT feature request A request for new functionality OS: Ubuntu
Projects
None yet
Development

No branches or pull requests

2 participants