Collect function

src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs

@@ -348,7 +348,8 @@ private TexlBinding(
                 entityName: EntityName,
                 propertyName: Property?.InvariantName ?? string.Empty,
                 allowsSideEffects: bindingConfig.AllowsSideEffects,
-                numberIsFloat: bindingConfig.NumberIsFloat);
+                numberIsFloat: bindingConfig.NumberIsFloat,
+                analysisMode: bindingConfig.AnalysisMode);
         }
 
         /// <summary>
@@ -2915,12 +2916,20 @@ public override void Visit(FirstNameNode node)
                         isConstantNamedFormula = formula.IsConstant;
                     }
                 }
-                else if (lookupInfo.Kind == BindKind.Data)
-                {
-                    if (lookupInfo.Data is IExternalCdsDataSource or IExternalTabularDataSource)
-                    {
-                        _txb.SetMutable(node, true);
-                    }
+                else if (lookupInfo.Kind == BindKind.Data)
+                {
+                    if (lookupInfo.Data is IExternalCdsDataSource or IExternalTabularDataSource)
+                    {
+                        _txb.SetMutable(node, true);
+                    }
+                    else if (lookupInfo.Data is IExternalDataSource ds)
+                    {
+                        _txb.SetMutable(node, ds.IsWritable);
+                    }
+                }
+                else if (lookupInfo.Kind == BindKind.ScopeCollection)
+                {
+                    _txb.SetMutable(node, true);
                 }
                 else if (lookupInfo.Kind == BindKind.ScopeCollection)
                 {

src/libraries/Microsoft.PowerFx.Core/Binding/BindingConfig.cs

@@ -19,13 +19,16 @@ internal class BindingConfig
 
         public bool UseThisRecordForRuleScope { get; }
 
-        public bool NumberIsFloat { get; }
+        public bool NumberIsFloat { get; }
+
+        public bool AnalysisMode { get; }
 
-        public BindingConfig(bool allowsSideEffects = false, bool useThisRecordForRuleScope = false, bool numberIsFloat = false)
+        public BindingConfig(bool allowsSideEffects = false, bool useThisRecordForRuleScope = false, bool numberIsFloat = false, bool analysisMode = false)
         {
             AllowsSideEffects = allowsSideEffects;
             UseThisRecordForRuleScope = useThisRecordForRuleScope;
-            NumberIsFloat = numberIsFloat;
+            NumberIsFloat = numberIsFloat;
+            AnalysisMode = analysisMode;
         }
     }
 }

src/libraries/Microsoft.PowerFx.Core/Functions/CheckTypesContext.cs

@@ -22,6 +22,8 @@ internal class CheckTypesContext
 
         public bool NumberIsFloat { get; }
 
+        public bool AnalysisMode { get; }
+
         public CheckTypesContext(Features features, INameResolver nameResolver, string entityName, string propertyName, bool allowsSideEffects, bool numberIsFloat)
         {
             Features = features;
@@ -30,6 +32,13 @@ public CheckTypesContext(Features features, INameResolver nameResolver, string e
             PropertyName = propertyName;
             AllowsSideEffects = allowsSideEffects;
             NumberIsFloat = numberIsFloat;
+            AnalysisMode = true;
+        }
+
+        public CheckTypesContext(Features features, INameResolver nameResolver, string entityName, string propertyName, bool allowsSideEffects, bool numberIsFloat, bool analysisMode)
+            : this(features, nameResolver, entityName, propertyName, allowsSideEffects, numberIsFloat)
+        {
+            AnalysisMode = analysisMode;
         }
     }
 }

src/libraries/Microsoft.PowerFx.Core/Functions/ISuggestionAwareFunction.cs

@@ -0,0 +1,14 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+namespace Microsoft.PowerFx.Core.Functions
+{
+    /// <summary>
+    /// Interface used for TexlFunctions to override the default behavior for intellisense suggestions.
+    /// </summary>
+    internal interface ISuggestionAwareFunction
+    {
+        // Returns true if it's valid to suggest ThisItem for this function as an argument.
+        bool CanSuggestThisItem { get; }
+    }
+}

src/libraries/Microsoft.PowerFx.Core/IR/CoercionMatrix.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-using Microsoft.PowerFx.Core.Entities;
 using Microsoft.PowerFx.Core.Types;
 using Microsoft.PowerFx.Core.Utils;
 

src/libraries/Microsoft.PowerFx.Core/Localization/Strings.cs

@@ -498,12 +498,14 @@ internal static class TexlStrings
         public static StringGetter PatchArg_Updates = (b) => StringResources.Get("PatchArg_Updates", b);
 
         public static StringGetter AboutCollect = (b) => StringResources.Get("AboutCollect", b);
-        public static StringGetter CollectDataSourceArg = (b) => StringResources.Get("CollectDataSourceArg", b);
-        public static StringGetter CollectRecordArg = (b) => StringResources.Get("CollectRecordArg", b);
+        public static StringGetter CollectArg1 = (b) => StringResources.Get("CollectArg1", b);
+        public static StringGetter CollectArg2 = (b) => StringResources.Get("CollectArg2", b);
+
+        public static StringGetter CollectItemArg = (b) => StringResources.Get("CollectItemArg", b);
+        public static StringGetter AboutCollect_data_source = (b) => StringResources.Get("AboutCollect_data_source", b);
+        public static StringGetter AboutCollect_item = (b) => StringResources.Get("AboutCollect_item", b);
 
         public static StringGetter AboutClearCollect = (b) => StringResources.Get("AboutClearCollect", b);
-        public static StringGetter ClearCollectDataSourceArg = (b) => StringResources.Get("ClearCollectDataSourceArg", b);
-        public static StringGetter ClearCollectRecordArg = (b) => StringResources.Get("ClearCollectRecordArg", b);
 
         public static StringGetter AboutRemove = (b) => StringResources.Get("AboutRemove", b);
         public static StringGetter RemoveDataSourceArg = (b) => StringResources.Get("RemoveDataSourceArg", b);