Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect function #2156

Merged
merged 63 commits into from
Jun 13, 2024
Merged

Collect function #2156

merged 63 commits into from
Jun 13, 2024

Conversation

anderson-joyle
Copy link
Contributor

This is a rebased version of #2122, with all comments addressed.

@anderson-joyle anderson-joyle added the Breaking Internals Breaking change - may require a PA Client update. label Jan 19, 2024
@anderson-joyle anderson-joyle requested a review from a team as a code owner January 19, 2024 22:47
@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 19, 2024

✅ No public API change. #Resolved

@anderson-joyle anderson-joyle force-pushed the andersonf/unify/collect-2 branch from 425e44f to 1cf414d Compare January 22, 2024 15:32
@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 22, 2024

✅ No public API change. #Resolved

@anderson-joyle anderson-joyle force-pushed the andersonf/unify/collect-2 branch from 1cf414d to 53b50bf Compare January 23, 2024 14:57
@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 23, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 24, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 29, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 30, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 31, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 1, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 2, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 5, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 5, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 22, 2024

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 23, 2024

✅ No public API change. #Resolved

MikeStall
MikeStall previously approved these changes Jun 12, 2024
@CarlosFigueiraMSFT
Copy link
Contributor

        var engine = new Engine(new PowerFxConfig(isPFxV1 ? Features.PowerFxV1 : Features.None));

Do we need this?


Refers to: src/tests/Microsoft.PowerFx.Core.Tests.Shared/TexlTests.cs:147 in cb757a3. [](commit_id = cb757a3, deletion_comment = False)

@CarlosFigueiraMSFT
Copy link
Contributor

        engine.Config.SymbolTable.AddFunction(new PatchAggregateSingleTableFunction());

[minor] can we just call EnableMutationFunctions instead of adding each function individually? If we don't call those, then we don't need the Patch functions either.


Refers to: src/tests/Microsoft.PowerFx.Core.Tests.Shared/TexlTests.cs:158 in cb757a3. [](commit_id = cb757a3, deletion_comment = False)

@anderson-joyle anderson-joyle merged commit 2e21513 into main Jun 13, 2024
4 checks passed
@anderson-joyle anderson-joyle deleted the andersonf/unify/collect-2 branch October 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Internals Breaking change - may require a PA Client update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants