build(server): upgrade eslint config and add compatibility workarounds #25892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
changed the title
alexvy86
reviewed
Nov 18, 2025
| '@fluid-tools/build-cli': | ||
| specifier: ^0.60.0 | ||
| version: 0.60.0(@types/node@22.10.7)([email protected])([email protected]) | ||
| version: 0.60.0(@types/node@18.19.39)([email protected])([email protected]) |
Contributor
There was a problem hiding this comment.
I'm a bit unsure the pnpm override actually had an effect here. I suspect something like what we've seen happen with Typescript 5.4.5 and 5.9.2; in this case it feels like the expected resolution would be v18 and some previous lockfile update incorrectly pushed it to 22, and this PR managed to correct that (which it probably would have done even without the override?).
It does make me wonder if the override should also clamp >22 to 18 instead of 20.
Member
Author
There was a problem hiding this comment.
It definitely did not work without the override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the ESLint configuration across all server/routerlicious packages and implements workarounds for compatibility issues.
ESLint Configuration Upgrade
@fluidframework/eslint-config-fluidfrom^6.1.0to^8.1.0across all packagesimport-xprefix (e.g.,import/no-nodejs-modules→import-x/no-nodejs-modules)import/namespacetoimport-x/namespacein inline eslint-disable commentsBuild Configuration Workarounds
^server/routerlicious/packages/.*/package.jsonto fluid-build for bothtsc-multiandfluid-build-tasks-tsctasksType Compatibility
@types/node@>=22override to force Node.js v20 types, working around incompatibilities with packages using different type versionsCode Quality Improvements
@typescript-eslint/return-awaitsuppression for false positive in localOrdererSetup.tsAll changes maintain backward compatibility while modernizing the linting infrastructure.