build(server): upgrade eslint config and add compatibility workarounds (#25892)

Author: tylerbutler

fluidBuild.config.cjs

@@ -344,8 +344,14 @@ module.exports = {
 				"^packages/test/test-utils/package.json",
 				// TODO: AB#7630 uses lint only ts projects for coverage which don't have representative tsc scripts
 				"^packages/tools/fluid-runner/package.json",
+
+				// Server packages need to be cleaned up; excluding as a workaround
+				"^server/routerlicious/packages/.*/package.json",
+			],
+			"fluid-build-tasks-tsc": [
+				// Server packages need to be cleaned up; excluding as a workaround
+				"^server/routerlicious/packages/.*/package.json",
 			],
-			"fluid-build-tasks-tsc": [],
 			"html-copyright-file-header": [
 				// Tests generate HTML "snapshot" artifacts
 				"tools/api-markdown-documenter/src/test/snapshots/.*",

server/routerlicious/package.json

@@ -139,10 +139,12 @@
 	"pnpm": {
 		"commentsOverrides": [
 			"@types/node is overridden to v18 to ensure all packages are building using the v18 types.",
+			"node types >= 22 are bumped down to 20.x to work around issues with packages using different types.",
 			"oclif includes some AWS-related features, but we don't use them, so we override those dependencies with empty packages. This helps reduce lockfile churn since the deps release very frequently."
 		],
 		"overrides": {
 			"@types/node@<18": "^18.19.39",
+			"@types/node@>=22": "^20.0.0",
 			"oclif>@aws-sdk/client-cloudfront": "npm:[email protected]",
 			"oclif>@aws-sdk/client-s3": "npm:[email protected]",
 			"qs": "^6.11.0",

server/routerlicious/packages/gitresources/package.json

@@ -32,7 +32,7 @@
 		"@fluid-tools/build-cli": "^0.60.0",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools": "^0.60.0",
-		"@fluidframework/eslint-config-fluid": "^6.1.0",
+		"@fluidframework/eslint-config-fluid": "^8.1.0",
 		"@fluidframework/gitresources-previous": "npm:@fluidframework/[email protected]",
 		"@microsoft/api-extractor": "^7.45.1",
 		"concurrently": "^8.2.1",

server/routerlicious/packages/kafka-orderer/package.json

@@ -35,7 +35,7 @@
 		"@fluid-tools/build-cli": "^0.60.0",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools": "^0.60.0",
-		"@fluidframework/eslint-config-fluid": "^6.1.0",
+		"@fluidframework/eslint-config-fluid": "^8.1.0",
 		"@fluidframework/server-kafka-orderer-previous": "npm:@fluidframework/[email protected]",
 		"@types/node": "^18.19.39",
 		"concurrently": "^8.2.1",

server/routerlicious/packages/lambdas-driver/.eslintrc.cjs

@@ -12,14 +12,14 @@ module.exports = {
 		project: ["./tsconfig.json", "./src/test/tsconfig.json"],
 	},
 	rules: {
-		"import/no-nodejs-modules": "off",
+		"import-x/no-nodejs-modules": "off",
 		"promise/catch-or-return": ["error", { allowFinally: true }],
 
 		// TODO: enable strict null checks in tsconfig and remove these overrides
 		"@typescript-eslint/prefer-nullish-coalescing": "off",
 		"@typescript-eslint/strict-boolean-expressions": "off",
 
 		// TODO: remove usages of deprecated APIs and remove this override
-		"import/no-deprecated": "warn",
+		"import-x/no-deprecated": "warn",
 	},
 };

server/routerlicious/packages/lambdas-driver/package.json

@@ -67,7 +67,7 @@
 		"@fluid-tools/build-cli": "^0.60.0",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools": "^0.60.0",
-		"@fluidframework/eslint-config-fluid": "^6.1.0",
+		"@fluidframework/eslint-config-fluid": "^8.1.0",
 		"@fluidframework/server-lambdas-driver-previous": "npm:@fluidframework/[email protected]",
 		"@fluidframework/server-test-utils": "workspace:~",
 		"@types/async": "^3.2.9",

server/routerlicious/packages/lambdas/.eslintrc.cjs

@@ -7,7 +7,7 @@ module.exports = {
 	extends: [require.resolve("@fluidframework/eslint-config-fluid"), "prettier"],
 	rules: {
 		"@rushstack/no-new-null": "off",
-		"import/no-nodejs-modules": "off",
+		"import-x/no-nodejs-modules": "off",
 		"promise/catch-or-return": ["error", { allowFinally: true }],
 		"unicorn/no-null": "off",
 
@@ -27,7 +27,7 @@ module.exports = {
 		"@typescript-eslint/prefer-nullish-coalescing": "off",
 
 		// TODO: remove usages of deprecated APIs and remove this override
-		"import/no-deprecated": "warn",
+		"import-x/no-deprecated": "warn",
 
 		// TODO: fix violations and remove this override
 		"@fluid-internal/fluid/no-unchecked-record-access": "warn",

server/routerlicious/packages/lambdas/package.json

@@ -80,7 +80,7 @@
 		"@fluid-tools/build-cli": "^0.60.0",
 		"@fluidframework/build-common": "^2.0.3",
 		"@fluidframework/build-tools": "^0.60.0",
-		"@fluidframework/eslint-config-fluid": "^6.1.0",
+		"@fluidframework/eslint-config-fluid": "^8.1.0",
 		"@fluidframework/server-lambdas-previous": "npm:@fluidframework/[email protected]",
 		"@fluidframework/server-test-utils": "workspace:~",
 		"@types/async": "^3.2.9",

server/routerlicious/packages/lambdas/src/nexus/index.ts

@@ -569,9 +569,9 @@ export function configureWebSocketServices(
 			/**
 			 * @param contentBatches - typed as `unknown` array as it comes from wire and has not been validated.
 			 * v1 signals are expected to be an array of strings (Json.stringified `ISignalEnvelope`s from
-			 * [Container.submitSignal](https://github.com/microsoft/FluidFramework/blob/ccb26baf65be1cbe3f708ec0fe6887759c25be6d/packages/loader/container-loader/src/container.ts#L2292-L2294)
+			 * {@link https://github.com/microsoft/FluidFramework/blob/ccb26baf65be1cbe3f708ec0fe6887759c25be6d/packages/loader/container-loader/src/container.ts#L2292-L2294|Container.submitSignal}
 			 * and sent via
-			 * [DocumentDeltaConnection.emitMessages](https://github.com/microsoft/FluidFramework/blob/ccb26baf65be1cbe3f708ec0fe6887759c25be6d/packages/drivers/driver-base/src/documentDeltaConnection.ts#L313C1-L321C4)),
+			 * {@link https://github.com/microsoft/FluidFramework/blob/ccb26baf65be1cbe3f708ec0fe6887759c25be6d/packages/drivers/driver-base/src/documentDeltaConnection.ts#L313C1-L321C4|DocumentDeltaConnection.emitMessages}
 			 * but actual content is passed-thru and not decoded.
 			 *
 			 * v2 signals are expected to be an array of `ISentSignalMessage` objects.

server/routerlicious/packages/lambdas/src/scribe/lambda.ts

@@ -584,7 +584,7 @@ export class ScribeLambda implements IPartitionLambda {
 					typeof message.contents === "string" &&
 					message.type !== MessageType.ClientLeave
 				) {
-					// eslint-disable-next-line import/namespace
+					// eslint-disable-next-line import-x/namespace
 					const clonedMessage = _.cloneDeep(message);
 					clonedMessage.contents = JSON.parse(clonedMessage.contents as string);
 					this.protocolHandler.processMessage(clonedMessage, false);