Skip to content

Extend Price Update in SubscriptionBilling #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2025
Merged

Extend Price Update in SubscriptionBilling #5388

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9805e74
Extend Price Update in SubscriptionBilling
klettatsinghammer Oct 31, 2025
8873869
Extend Price Update in SubscriptionBilling
klettatsinghammer Nov 3, 2025
03ca42f
Move central publisher to three individual publishers
klettatsinghammer Nov 12, 2025
421c1a5
Merge branch 'main' into dkl_SC250547
JesperSchulz Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ubscription Billing/App/Contract Price Update/Codeunits/CalculationBaseByPerc.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ namespace Microsoft.SubscriptionBilling;

codeunit 8010 "Calculation Base By Perc" implements "Contract Price Update"
{
Access = Internal;

var
PriceUpdateTemplate: Record "Price Update Template";
ServiceCommitment: Record "Subscription Line";
Expand Down Expand Up @@ -37,6 +35,7 @@ codeunit 8010 "Calculation Base By Perc" implements "Contract Price Update"
ContractPriceUpdateLine.UpdateFromContract(ServiceCommitment.Partner, ServiceCommitment."Subscription Contract No.");
CalculateNewPrice(PriceUpdateTemplate."Update Value %", ContractPriceUpdateLine);
ContractPriceUpdateLine."Next Price Update" := CalcDate(PriceUpdateTemplate."Price Binding Period", ContractPriceUpdateLine."Perform Update On");
OnAfterCalculateNewPriceForSubscriptionLine(ServiceCommitment, ContractPriceUpdateLine, PriceUpdateTemplate, PerformUpdateOnDate);
if ContractPriceUpdateLine.ShouldContractPriceUpdateLineBeInserted() then
ContractPriceUpdateLine.Insert(false)
else
Expand All @@ -51,4 +50,9 @@ codeunit 8010 "Calculation Base By Perc" implements "Contract Price Update"
NewContractPriceUpdateLine."New Calculation Base" := NewContractPriceUpdateLine."Old Calculation Base";
NewContractPriceUpdateLine.CalculateNewPrice();
end;

[IntegrationEvent(false, false)]
internal procedure OnAfterCalculateNewPriceForSubscriptionLine(SubscriptionLine: Record "Subscription Line"; var SubContrPriceUpdateLine: Record "Sub. Contr. Price Update Line"; PriceUpdateTemplate: Record "Price Update Template"; PerformUpdateOnDate: Date)
begin
end;
}
8 changes: 6 additions & 2 deletions ...ps/W1/Subscription Billing/App/Contract Price Update/Codeunits/PriceByPercent.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ using Microsoft.Finance.Currency;

codeunit 8012 "Price By Percent" implements "Contract Price Update"
{
Access = Internal;

var
PriceUpdateTemplate: Record "Price Update Template";
ServiceCommitment: Record "Subscription Line";
Expand Down Expand Up @@ -39,6 +37,7 @@ codeunit 8012 "Price By Percent" implements "Contract Price Update"
ContractPriceUpdateLine.UpdateFromContract(ServiceCommitment.Partner, ServiceCommitment."Subscription Contract No.");
CalculateNewPrice(PriceUpdateTemplate."Update Value %", ContractPriceUpdateLine);
ContractPriceUpdateLine."Next Price Update" := CalcDate(PriceUpdateTemplate."Price Binding Period", ContractPriceUpdateLine."Perform Update On");
OnAfterCalculateNewPriceForSubscriptionLine(ServiceCommitment, ContractPriceUpdateLine, PriceUpdateTemplate, PerformUpdateOnDate);
if ContractPriceUpdateLine.ShouldContractPriceUpdateLineBeInserted() then
ContractPriceUpdateLine.Insert(false)
else
Expand All @@ -60,4 +59,9 @@ codeunit 8012 "Price By Percent" implements "Contract Price Update"
NewContractPriceUpdateLine."New Amount" := NewContractPriceUpdateLine."New Amount" - NewContractPriceUpdateLine."Discount Amount";
NewContractPriceUpdateLine."Additional Amount" := NewContractPriceUpdateLine."New Amount" - NewContractPriceUpdateLine."Old Amount";
end;

[IntegrationEvent(false, false)]
internal procedure OnAfterCalculateNewPriceForSubscriptionLine(SubscriptionLine: Record "Subscription Line"; var SubContrPriceUpdateLine: Record "Sub. Contr. Price Update Line"; PriceUpdateTemplate: Record "Price Update Template"; PerformUpdateOnDate: Date)
begin
end;
}
8 changes: 6 additions & 2 deletions ...s/W1/Subscription Billing/App/Contract Price Update/Codeunits/RecentItemPrice.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ namespace Microsoft.SubscriptionBilling;

codeunit 8011 "Recent Item Price" implements "Contract Price Update"
{
Access = Internal;

var
PriceUpdateTemplate: Record "Price Update Template";
ServiceCommitment: Record "Subscription Line";
Expand Down Expand Up @@ -37,6 +35,7 @@ codeunit 8011 "Recent Item Price" implements "Contract Price Update"
ContractPriceUpdateLine.UpdateFromContract(ServiceCommitment.Partner, ServiceCommitment."Subscription Contract No.");
CalculateNewPrice(PriceUpdateTemplate."Update Value %", ContractPriceUpdateLine);
ContractPriceUpdateLine."Next Price Update" := CalcDate(PriceUpdateTemplate."Price Binding Period", ContractPriceUpdateLine."Perform Update On");
OnAfterCalculateNewPriceForSubscriptionLine(ServiceCommitment, ContractPriceUpdateLine, PriceUpdateTemplate, PerformUpdateOnDate);
if ContractPriceUpdateLine.ShouldContractPriceUpdateLineBeInserted() then
ContractPriceUpdateLine.Insert(false)
else
Expand All @@ -51,4 +50,9 @@ codeunit 8011 "Recent Item Price" implements "Contract Price Update"
NewContractPriceUpdateLine.CalculateNewCalculationBaseAmount();
NewContractPriceUpdateLine.CalculateNewPrice();
end;

[IntegrationEvent(false, false)]
internal procedure OnAfterCalculateNewPriceForSubscriptionLine(SubscriptionLine: Record "Subscription Line"; var SubContrPriceUpdateLine: Record "Sub. Contr. Price Update Line"; PriceUpdateTemplate: Record "Price Update Template"; PerformUpdateOnDate: Date)
begin
end;
}
6 changes: 6 additions & 0 deletions src/Apps/W1/Subscription Billing/App/Service Commitments/Tables/SubscriptionLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,6 +1686,7 @@ table 8059 "Subscription Line"
Rec.Modify(true);
Rec.SetSkipArchiving(false);
Rec.CreateServiceCommitmentArchive(ServiceCommitmentArchive, xServiceCommitment, CalcDate('<-1D>', ContractPriceUpdateLine."Perform Update On"), Enum::"Type Of Price Update"::"Price Update");
OnAfterUpdateServiceCommitmentFromContractPriceUpdateLine(Rec, ContractPriceUpdateLine);
end;

internal procedure ServiceCommitmentArchiveExistsForPeriodExists(var ServiceCommitmentArchive: Record "Subscription Line Archive"; RecurringBillingFrom: Date; RecurringBillingTo: Date): Boolean
Expand Down Expand Up @@ -2082,4 +2083,9 @@ table 8059 "Subscription Line"
local procedure OnBeforeCheckServiceDates(ServiceStartDate: Date; ServiceEndDate: Date; NextBillingDate: Date; var IsHandled: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterUpdateServiceCommitmentFromContractPriceUpdateLine(var SubscriptionLine: Record "Subscription Line"; SubContractPriceUpdateLine: Record "Sub. Contr. Price Update Line")
begin
end;
}
Loading