-
Notifications
You must be signed in to change notification settings - Fork 289
Extend Price Update in SubscriptionBilling #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miljance
reviewed
Oct 31, 2025
...1/Subscription Billing/App/Contract Price Update/Codeunits/PriceUpdateManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
miljance
reviewed
Oct 31, 2025
src/Apps/W1/Subscription Billing/App/Service Commitments/Tables/SubscriptionLine.Table.al
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@microsoft-github-policy-service agree company="Singhammer IT Consulting AG" |
After code review Fixes microsoft#5374
miljance
approved these changes
Nov 17, 2025
Contributor
miljance
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
djukicmilica
previously approved these changes
Nov 17, 2025
This was referenced Nov 17, 2025
AndersLarsenMicrosoft
pushed a commit
that referenced
this pull request
Nov 20, 2025
#### Summary This is a Backport of PR #5388 from main (28.0) to 27.x #### Work Item(s) Fixes #5374 [AB#613296](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/613296)
AndersLarsenMicrosoft
previously approved these changes
Nov 20, 2025
421c1a5
JesperSchulz
approved these changes
Nov 24, 2025
AndersLarsenMicrosoft
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AL: Apps (W1)
Add-on apps for W1
Approved
The issue is approved
Finance
GitHub request for Finance area
From Fork
Pull request is coming from a fork
Linked
Issue is linked to a Azure Boards work item
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to implement a retroactive price adjustment for the price update of subscription lines ("Contract Price Update"). To do this we want to create a copy of a subscription line during the price adjustment and change the date values of the subscription line depending on the value provided in the page "Contract Price Update".
Fixes #5374
AB#613284