-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[GenAI] Fix 11755: Providing a sensible default implementation in the base class that returns a new ConnectionPoolConfiguration instance
#12146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jarvx
wants to merge
2
commits into
micronaut-projects:4.10.x
Choose a base branch
from
Jarvx:fix-11755
base: 4.10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
test-suite-kotlin-ksp/src/test/java/io/micronaut/reproduce/ReproduceIssueTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package io.micronaut.reproduce; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * Trivial test whose only purpose is to ensure the test sources are compiled. | ||
| * If HttpClientConfiguration#getConnectionPoolConfiguration() is abstract, | ||
| * compilation will fail because TwitterHttpClientConfiguration does not | ||
| * implement that method (matching the user-guide example). | ||
| */ | ||
| public class ReproduceIssueTest { | ||
|
|
||
| @Test | ||
| void compileOnlySmoke() { | ||
| // Intentionally empty. Successful compilation of the test sources | ||
| // (which include TwitterHttpClientConfiguration) indicates the | ||
| // framework does not declare getConnectionPoolConfiguration() as abstract. | ||
| } | ||
| } | ||
25 changes: 25 additions & 0 deletions
25
...suite-kotlin-ksp/src/test/java/io/micronaut/reproduce/TwitterHttpClientConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package io.micronaut.reproduce; | ||
|
|
||
| import jakarta.inject.Named; | ||
| import jakarta.inject.Singleton; | ||
|
|
||
| import io.micronaut.http.client.HttpClientConfiguration; | ||
| import io.micronaut.runtime.ApplicationConfiguration; | ||
|
|
||
| /** | ||
| * Mirrors the user-guide example: a concrete subclass of | ||
| * io.micronaut.http.client.HttpClientConfiguration that does not | ||
| * override getConnectionPoolConfiguration(). | ||
| * | ||
| * If HttpClientConfiguration#getConnectionPoolConfiguration() is declared | ||
| * abstract in the framework (as reported in the issue), this class will | ||
| * fail to compile because it does not implement that method. | ||
| */ | ||
| @Named("twitter") | ||
| @Singleton | ||
| public class TwitterHttpClientConfiguration extends HttpClientConfiguration { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does this even do? It isn't referenced anywhere |
||
|
|
||
| public TwitterHttpClientConfiguration(ApplicationConfiguration configuration) { | ||
| super(configuration); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't make sense to place test code into a kotlin submodule that is Java. All tests should be collocated near the functionality they address, in this case in the http-client-core module