[GenAI] Fix 11755: Providing a sensible default implementation in the base class that returns a new ConnectionPoolConfiguration instance
#12146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11755
Bug description
TwitterHttpClientConfigurationdoes not compile becausegetConnectionPoolConfiguration()must be implemented.Root cause & Fix
The issue is that
HttpClientConfiguration.getConnectionPoolConfiguration()is declared abstract, forcing subclasses (like user examples) to implement it. To fix this without changing the behavior of existing concrete classes, we can provide a sensible default implementation in the base class that returns a newConnectionPoolConfigurationinstance. Subclasses that already override the method (e.g.DefaultHttpClientConfiguration,ServiceHttpClientConfiguration) will continue to work unchanged. This is a minimal, backward-compatible change.Steps to reproduce
Please use this command to see the test result: