New leak detection for tests #12139
Draft
New leak detection for tests #12139
+52
−301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty 4.2.7 introduced a new leak detection mechanism for tests that is more reliable and has lower overhead. micronaut-projects/micronaut-test#1291 introduces a micronaut-test module that uses this new mechanism. However, the new detector is more strict about resource lifetimes, so tests need various small adjustments: - Contexts must be closed at the end of the test - Event loops must be shut down - Tests must use only threads created in those tests (no Finalizers, no reactive boundedElastic) - SSL contexts must be released immediately There is also one minor leak fix in this PR, related to h2c support, in Http2ServerHandler. Draft because this requires the new micronaut-test module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty 4.2.7 introduced a new leak detection mechanism for tests that is more reliable and has lower overhead. micronaut-projects/micronaut-test#1291 introduces a micronaut-test module that uses this new mechanism. However, the new detector is more strict about resource lifetimes, so tests need various small adjustments:
There is also one minor leak fix in this PR, related to h2c support, in Http2ServerHandler.
Draft because this requires the new micronaut-test module.