feat(12135): Adding support for list access using env variables #12136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davidgammon-mettle
force-pushed
the
4.10.x
branch
2 times, most recently
from
a15ed02 to
26022fe
Compare
davidgammon-mettle
force-pushed
the
4.10.x
branch
from
26022fe to
3ae0c10
Compare
|
@davidgammon-mettle need a test |
Added. |
davidgammon-mettle
force-pushed
the
4.10.x
branch
from
c4e39f0 to
97c314b
Compare
graemerocher
requested changes
Oct 20, 2025
| continue; | ||
| } | ||
| result.put(envVar, entry.getValue()); | ||
| Map<String, String> result = new HashMap<>(); |
There was a problem hiding this comment.
should be a LinkedHashMap to retain order
There was a problem hiding this comment.
existing code but updated as per comment.
| /** | ||
| * Converts list elemtents defined as _0 or _0_ into names that the resolver can understand; i.e., [0]. | ||
| */ | ||
| private static final String LIST_CONVERTER_REGEX = "_([0-9]{1,2})(?:_|$)"; |
There was a problem hiding this comment.
pre compile this regex
davidgammon-mettle
force-pushed
the
4.10.x
branch
from
e0f020b to
16bcc84
Compare
davidgammon-mettle
force-pushed
the
4.10.x
branch
from
16bcc84 to
41eb0c9
Compare
graemerocher
approved these changes
Oct 20, 2025
|
@graemerocher looks like the failed build might have been a victim of the aws outage? Any chance of rerunning the build? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ticket: #12135