-
Notifications
You must be signed in to change notification settings - Fork 14
Support membrane protein in a3fe via Gromacs-based System Preparation #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roy-Haolin-Du
wants to merge
5
commits into
michellab:feature-membrane-protein-eq
Choose a base branch
from
Roy-Haolin-Du:feature-membrane-protein-eq
base: feature-membrane-protein-eq
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
47c5c4c
Support membrane protein in a3fe via Gromacs-based System Preparation
Roy-Haolin-Du a07fde4
Some extensive docs for membrane protein
Roy-Haolin-Du 1b84f02
Adjusted code formatting, updated CHANGELOG and version
Roy-Haolin-Du 5a0d6e5
Add support for Protein non-Protein temperature coupling groups for n…
Roy-Haolin-Du 539bc33
Modify guide docs as well
Roy-Haolin-Du File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.3.3" | ||
| __version__ = "0.3.4" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -276,4 +276,29 @@ Since A3FE 0.2.0, ABFE calculations with charged ligands are supported using a c | |
| cutoff type = PME | ||
| cutoff distance = 10 * angstrom | ||
|
|
||
| The default `template_config.cfg` uses reaction field instead of PME. This is faster (around twice as fast for some of our systems) and has been shown to give equivalent results for neutral ligands in RBFE calculations - see https://pubs.acs.org/doi/full/10.1021/acs.jcim.0c01424 . | ||
| The default `template_config.cfg` uses reaction field instead of PME. This is faster (around twice as fast for some of our systems) and has been shown to give equivalent results for neutral ligands in RBFE calculations - see https://pubs.acs.org/doi/full/10.1021/acs.jcim.0c01424 . | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, docs look great! Only thing (which you were probably planning anyway) is to update the changelog. |
||
|
|
||
| ABFE with Membrane Proteins | ||
| *************************** | ||
|
|
||
| Since A3FE 0.3.4, ABFE calculations with membrane proteins are supported via gromacs for minimization, NVT, NPT, and ensemble equilibration. The only change in the input required is that the use of barostat_membrane, rather than barostat, should be specified in ``template_config.cfg`` as e.g.: | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| ### Barostat ### | ||
| barostat = False | ||
| barostat_membrane = True | ||
|
|
||
| By modifying the ``SystemPreparationConfig`` object as described above, we can now try running membrane protein abfe calculation. | ||
| Note that this is expected to change the template_config.cfg file in the same time. | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| import a3fe as a3 | ||
| cfg = a3.SystemPreparationConfig(membrane_protein=True) | ||
| calc = a3.Calculation() | ||
| calc.setup(bound_leg_sysprep_config = cfg, free_leg_sysprep_config = cfg) | ||
|
|
||
| However, users must provide the ``bound_solv`` and ``free_solv`` files externally, as automated parameterization and solvation are not yet supported. | ||
| Additionally, the configuration files (gromacs.mdp) for these preparation steps specified in ``get_membrane_nvt_config`` and ``get_membrane_npt_config`` functions of ``system_prep.py`` file in which is general and not highly specialized; | ||
| Thus, it is recommended that users perform these pre-equilibration steps externally. Future updates will address these limitations. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| Warnings | ||
| ======== | ||
|
|
||
| - We do no recommend running ABFE calculations with membrane proteins using the current version of ``a3fe``. This is because SOMD (Sire/ OpenMM Molecular Dynamics, part of Sire) is used for the free energy calculations (after setup with GROMACS), and currently SOMD uses an isotropic barostat. We plan to implement support for ABFE with GROMACS in the future. | ||
| - ABFE calculations with membrane proteins are supported via GROMACS for minimization, NVT, NPT, and ensemble equilibration. | ||
| However, the configuration file (gromacs.mdp) used for these preparation steps is general and non-specialized. | ||
| It is currently recommended that users perform the pre-equilibration procedures externally. | ||
| Nevertheless, future releases will include support for these steps and we also plan to implement support ABFE calculations with GROMACS in the future. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.