-
Notifications
You must be signed in to change notification settings - Fork 14
Support membrane protein in a3fe via Gromacs-based System Preparation #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature-membrane-protein-eq
Are you sure you want to change the base?
Support membrane protein in a3fe via Gromacs-based System Preparation #49
Conversation
|
Thanks for this Roy - looks good! Let me know if/ when you'd like a review and I'm happy to take a look! |
|
@fjclark Thanks, Finlay, I definitely appreciate your advice! The current idea is to first modify the system preparation in A3FE to support membrane-specific configurations, and later on, BioSimSpace will natively support membrane configuration for gromacs. The change I made is pretty low-level, I simply took advantage of So could please review it? I’d be sincerely grateful for any suggestions or comments you might have. In addition, Julien suggested having Silvia test it before merging. I’ll also listen to her feedback. Thanks. |
fjclark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Roy! Just a couple of minor/ pedantic comments.
| cutoff distance = 10 * angstrom | ||
| The default `template_config.cfg` uses reaction field instead of PME. This is faster (around twice as fast for some of our systems) and has been shown to give equivalent results for neutral ligands in RBFE calculations - see https://pubs.acs.org/doi/full/10.1021/acs.jcim.0c01424 . | ||
| The default `template_config.cfg` uses reaction field instead of PME. This is faster (around twice as fast for some of our systems) and has been shown to give equivalent results for neutral ligands in RBFE calculations - see https://pubs.acs.org/doi/full/10.1021/acs.jcim.0c01424 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, docs look great! Only thing (which you were probably planning anyway) is to update the changelog.
|
Mention for myself. For temperature coupling groups (protein/membrane/solvent separation) in We can create a custom wrapper for
However, the limitation discovered Practical Workaround: Use gmx predefined groups |
…vt npt membrane proteins
|
Add membrane protein temperature coupling with Protein non-Protein groups.
As BSS seems not support custom index files for these groups.(-n index.ndx) .OpenBioSim/biosimspace#405. Hi Finlay @fjclark |
|
Hi Finlay, |
|
@Roy-Haolin-Du I don't know if you mentioned it already, but when simulating the FREE leg in the context of membrane protein systems, the barostat should be the normal isotropic one in the In my personal version I put a switch in the In this way, the bound leg with the membrane is simualted with the semi-isotropic barostat, while the free leg it is always simulated using the isotropic one, since the system is always a simple water box with the ligand |
|
Hi @silviamenin Thanks a lot for pointing this out, I didn’t know! |
Description
Ensure ABFE calculations with membrane proteins are supported via gromacs for minimization, NVT, NPT, and ensemble equilibration.
template_config.cfg.SystemPreparationConfigobject viacfg = a3.SystemPreparationConfig(membrane_protein=True).bound_solvandfree_solvfiles externally, as automated parameterization and solvation are not yet supported.get_membrane_equilibration_configfunction ofsystem_prep.pyfile in which is general and not highly specialized; Thus, it is recommended that users perform these pre-equilibration steps externally. Future updates will address these limitations.Close #48.
Todos
Status