Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirrord binary download improvements #180

Merged
merged 13 commits into from
Nov 21, 2023
Merged

mirrord binary download improvements #180

merged 13 commits into from
Nov 21, 2023

Conversation

infiniteregrets
Copy link
Contributor

@infiniteregrets infiniteregrets commented Oct 16, 2023 •
edited
Loading

This PR:

  • removes quotes around GITHUB_PATH could be a potential error
  • adds a check for CI builds to choose the release builds as their tag is greater than the latest release

meowjesty
meowjesty approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@infiniteregrets infiniteregrets changed the title Remove quotes around GITHUB_PATH in e2e mirrord binary download improvements Nov 12, 2023
@infiniteregrets infiniteregrets added this pull request to the merge queue Nov 21, 2023
Merged via the queue into metalbear-co:main with commit 88039fe Nov 21, 2023
5 checks passed
@infiniteregrets infiniteregrets deleted the release-ci-fix branch November 21, 2023 16:01
@infiniteregrets infiniteregrets mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowjesty meowjesty meowjesty approved these changes

@Razz4780 Razz4780 Razz4780 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infiniteregrets @Razz4780 @meowjesty