Add multi index and disjunctive facet search #888

bidoubiwa · 2022-11-23T16:38:23Z

Using the Index widget, it is now possible to do mult-index search, see example bellow.

By introducing the multi index search. we automatically introduce disjunctive facet search.

Related to: #774 #789

Multi index search

    <InstantSearch indexName="movies" searchClient={searchClient}>
      <SearchBox />
      <h2>Movies</h2>
      <Index indexName="movies">
        <Hits hitComponent={Hit} />
      </Index>
      <h2>Games</h2>
      <Index indexName="games">
        <Hits hitComponent={Hit} />
      </Index>
    </InstantSearch>

multi-index-1.mp4

Disjunctive facet search

disjunctive.mp4

Multi index + disjunctive facet search

multi-disjunctive.mp4

TODO

Should work on simple search
Should be compatible with following widgets:
- Pagination
- RefinementList
Should be compatible with all Meilisearch parameters
- placeholder search
- finite pagination
- keep zero facets Fix keepZeroFacets on disjunctive facet search #918
check state of cache

src/client/instant-meilisearch-client.ts

tsconfig.test.json

Co-authored-by: Morgane Dubus <[email protected]>

mdubus

LGTM ✨ 🦕

…ps://github.com/meilisearch/instant-meilisearch into bump-meilisearch-v0.30.0-add_multi_index_search

mdubus

LGTM ✨🦕

brunoocasali · 2022-12-06T17:16:54Z

tests/multi-index-search.tests.ts

+    expect(emptyMovies.hits.length).toBe(0)
+    expect(emptyGames.hits.length).toBe(0)
+
+    const response = await customClient.search<Movies>([


Suggested change

const response = await customClient.search<Movies>([

const response = await customClient.search<Movies>([

I want to understand this signature better since now you'll return two different types. What do these Movies does in this case? Can we get rid of it?

Instantsearch requires a search method with a generic. Nonetheless, you are right that it makes no sense as there are multiple indexes now.

I looked at the code of algoliasearch and it seems the issue is at their side as well. multipleQueries is the method used for searching in instantsearch, see their searchClient.

…o bump-meilisearch-v0.30.0-add_multi_index_search

cypress/integration/search-ui.spec.js

brunoocasali · 2022-12-07T17:16:02Z

cypress/integration/search-ui.spec.js

@@ -78,6 +81,6 @@ describe(`${playground} playground test`, () => {

  it('Paginate Search', () => {
    cy.get('.ais-InfiniteHits-loadMore').click()
-    cy.get(HIT_ITEM_CLASS).should('have.length', 11)
+    cy.get(HIT_ITEM_CLASS).should('have.length', 12)


Why this has been changed?

because of the disjunctive facet search accepting more hits in return 😅

brunoocasali · 2022-12-07T17:17:05Z

scripts/jest_teardown.js

+  await client.deleteIndex('movies')
+  const task = await client.deleteIndex('games')
+
+  await client.waitForTask(task.taskUid)


Don't you have a method that accepts more than one uid? (or I'm misleading because of other SDKs...)

I don't have one in js :(

bidoubiwa · 2022-12-08T14:11:52Z

bors merge

bidoubiwa · 2022-12-08T14:12:12Z

bors r-

888: Add multi index and disjunctive facet search r=bidoubiwa a=bidoubiwa ⚠️ NOT working with `keepzerofacet` Using the `Index` widget, it is now possible to do mult-index search, see example bellow. By introducing the multi index search. we automatically introduce disjunctive facet search. Related to: #774 #789 # Multi index search ```jsx <InstantSearch indexName="movies" searchClient={searchClient}> <SearchBox /> <h2>Movies</h2> <Index indexName="movies"> <Hits hitComponent={Hit} /> </Index> <h2>Games</h2> <Index indexName="games"> <Hits hitComponent={Hit} /> </Index> </InstantSearch> ``` https://user-images.githubusercontent.com/33010418/203822998-8fc99a62-970f-42a9-95bb-ab09d3c67a9d.mp4 ## Disjunctive facet search https://user-images.githubusercontent.com/33010418/204564207-576bca0c-344b-427c-a1a1-e10ddd7a677f.mp4 # Multi index + disjunctive facet search https://user-images.githubusercontent.com/33010418/204565010-d4564fdb-88a0-46ad-8dc0-bb6761798e49.mp4 ## TODO - [x] Should work on simple search - [x] Should be compatible with following widgets: - [x] Pagination - [x] RefinementList - [x] Should be compatible with all Meilisearch parameters - [x] placeholder search - [x] finite pagination - [ ] keep zero facets ⚠️ Fixed in disjunctive facet search PR - [x] check state of cache Co-authored-by: Charlotte Vermandel <[email protected]> Co-authored-by: cvermand <[email protected]>

meili-bors · 2022-12-08T14:12:15Z

Canceled.

bidoubiwa · 2022-12-08T14:13:37Z

bors merge

meili-bors · 2022-12-08T14:16:07Z

Build succeeded:

918: Fix keepZeroFacets on disjunctive facet search r=bidoubiwa a=bidoubiwa Since introducing the multi-index search here #888 the setting `keepZeroFacets` was broken. This PR introduces the fix to this issue https://user-images.githubusercontent.com/33010418/207385436-e49ded20-e76b-4974-86de-904cfeecfbd7.mp4 What was done in this pr: - keepZeroFacet management has been moved to the response adapter instead of the request adapter - Filtering methods and filtering tests were removed as the new facet distribution management has completely changed - `defaultFacetDistribution` is renamed `initialFacetDistribution` and contains the distribution of an index without any other requests - Initialization of facet distribution was moved from client to its own file Playgrounds: - New SingleMovieIndex playground to create a new environment for testing - Updated `SingleIndex` with keepZeroFacets - Updated `MultiIndex` with keepZeroFacets Co-authored-by: Charlotte Vermandel <[email protected]>

915: Beta: Multi index search and disjunctive facet search r=bidoubiwa a=bidoubiwa see #888 Body of the release: ## ⚠️ Breaking change - Facets behavior changed and uses `disjunctive facet search` see #884 added in #888 ## 🚀 Enchancement - The `Index` widget is now compatible with instant-meilisearch #888 Thanks again to `@bidoubiwa!` 🎉 Co-authored-by: Charlotte Vermandel <[email protected]> Co-authored-by: cvermand <[email protected]>

Add disjunctive facet search

3302604

bidoubiwa mentioned this pull request Nov 23, 2022

Add disjunctive facet search #887

Closed

Add condition on filtering caching

29bda1f

bidoubiwa force-pushed the bump-meilisearch-v0.30.0-add_multi_index_search branch from 3480333 to 29bda1f Compare November 23, 2022 16:43

bidoubiwa mentioned this pull request Nov 24, 2022

"or" operator doesn't seem to work within a refinement list (disjunctive facet search). #789

Closed

Add multi index search

bb0ef01

bidoubiwa requested review from brunoocasali and mdubus November 24, 2022 15:27

Add datasets in tests assets

07760b6

mdubus reviewed Nov 24, 2022

View reviewed changes

src/client/instant-meilisearch-client.ts Outdated Show resolved Hide resolved

tsconfig.test.json Show resolved Hide resolved

Update src/client/instant-meilisearch-client.ts

073adf0

Co-authored-by: Morgane Dubus <[email protected]>

bidoubiwa marked this pull request as ready for review November 24, 2022 15:45

mdubus previously approved these changes Nov 24, 2022

View reviewed changes

bidoubiwa marked this pull request as draft November 24, 2022 15:50

bidoubiwa added 6 commits November 24, 2022 19:18

Improve filters

7b4fc20

Improve readme

ee46536

Merge branch 'bump-meilisearch-v0.30.0-add_multi_index_search' of htt…

560763d

…ps://github.com/meilisearch/instant-meilisearch into bump-meilisearch-v0.30.0-add_multi_index_search

fix merge conflicts

a224d1a

Remove console logs from client

8179471

Remove comments

4e1fbb2

Base automatically changed from bump-meilisearch-v0.30.0 to main November 28, 2022 15:25

meili-bors bot dismissed mdubus’s stale review via 4e1fbb2 November 28, 2022 15:25

bidoubiwa added 3 commits November 29, 2022 14:34

Add tests on disjunctive facet search

b33b7d9

remove console log

4547b56

Update playground

238ee58

bidoubiwa added the enhancement New feature or request label Nov 29, 2022

bidoubiwa changed the title ~~Add multi index search~~ Add multi index and disjunctive facet search Nov 29, 2022

bidoubiwa marked this pull request as ready for review November 29, 2022 15:17

bidoubiwa added 2 commits November 29, 2022 16:18

Add logging on react setup

43a3dac

Improve README

9f06d09

bidoubiwa requested a review from mdubus November 29, 2022 18:47

mdubus previously approved these changes Nov 30, 2022

View reviewed changes

bidoubiwa mentioned this pull request Dec 6, 2022

Add disjunctive facet search #884

Closed

brunoocasali reviewed Dec 6, 2022

View reviewed changes

bidoubiwa added 2 commits December 7, 2022 15:07

Merge branch 'main' of github.com:meilisearch/instant-meilisearch int…

e7b7ca8

…o bump-meilisearch-v0.30.0-add_multi_index_search

Fix end to end tests

2daa5c2

bidoubiwa dismissed mdubus’s stale review via 2daa5c2 December 7, 2022 16:16

bidoubiwa added 4 commits December 7, 2022 17:20

Fix linting error

c833807

Update selectors in cypress to improve tests

b1f785d

Add json module resolver for tests

1bf47bf

Add a wait in cypress method resolving to fast

42edcde

brunoocasali previously approved these changes Dec 7, 2022

View reviewed changes

Remove useless wait in search-ui specs

a6ab3fa

bidoubiwa dismissed brunoocasali’s stale review via a6ab3fa December 7, 2022 17:30

bidoubiwa requested a review from brunoocasali December 7, 2022 17:42

brunoocasali approved these changes Dec 7, 2022

View reviewed changes

bidoubiwa changed the base branch from main to beta/multi-index-search December 8, 2022 14:13

meili-bors bot merged commit 170fed7 into beta/multi-index-search Dec 8, 2022

meili-bors bot deleted the bump-meilisearch-v0.30.0-add_multi_index_search branch December 8, 2022 14:16

This was referenced Dec 8, 2022

Beta: Multi index search and disjunctive facet search #915

Merged

Fix keepZeroFacets on disjunctive facet search #918

Merged

bidoubiwa mentioned this pull request Jan 4, 2023

Implement multi-index search #774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add multi index and disjunctive facet search #888

Add multi index and disjunctive facet search #888

bidoubiwa commented Nov 23, 2022 •

edited

Loading

mdubus left a comment

mdubus left a comment

brunoocasali Dec 6, 2022

bidoubiwa Dec 7, 2022 •

edited

Loading

brunoocasali Dec 7, 2022

bidoubiwa Dec 7, 2022

brunoocasali Dec 7, 2022

bidoubiwa Dec 7, 2022

bidoubiwa commented Dec 8, 2022

bidoubiwa commented Dec 8, 2022

meili-bors bot commented Dec 8, 2022

bidoubiwa commented Dec 8, 2022

meili-bors bot commented Dec 8, 2022

	const response = await customClient.search<Movies>([
	const response = await customClient.search<Movies>([

Add multi index and disjunctive facet search #888

Add multi index and disjunctive facet search #888

Conversation

bidoubiwa commented Nov 23, 2022 • edited Loading

Multi index search

Disjunctive facet search

Multi index + disjunctive facet search

TODO

mdubus left a comment

Choose a reason for hiding this comment

mdubus left a comment

Choose a reason for hiding this comment

brunoocasali Dec 6, 2022

Choose a reason for hiding this comment

bidoubiwa Dec 7, 2022 • edited Loading

Choose a reason for hiding this comment

brunoocasali Dec 7, 2022

Choose a reason for hiding this comment

bidoubiwa Dec 7, 2022

Choose a reason for hiding this comment

brunoocasali Dec 7, 2022

Choose a reason for hiding this comment

bidoubiwa Dec 7, 2022

Choose a reason for hiding this comment

bidoubiwa commented Dec 8, 2022

bidoubiwa commented Dec 8, 2022

meili-bors bot commented Dec 8, 2022

bidoubiwa commented Dec 8, 2022

meili-bors bot commented Dec 8, 2022

bidoubiwa commented Nov 23, 2022 •

edited

Loading

bidoubiwa Dec 7, 2022 •

edited

Loading