Merge #918

918: Fix keepZeroFacets on disjunctive facet search r=bidoubiwa a=bidoubiwa

Since introducing the multi-index search here #888 the setting `keepZeroFacets` was broken.

This PR introduces the fix to this issue


https://user-images.githubusercontent.com/33010418/207385436-e49ded20-e76b-4974-86de-904cfeecfbd7.mp4

What was done in this pr:

- keepZeroFacet management has been moved to the response adapter instead of the request adapter
- Filtering methods and filtering tests were removed as the new facet distribution management has completely changed
- `defaultFacetDistribution` is renamed `initialFacetDistribution` and contains the distribution of an index without any other requests
- Initialization of facet distribution was moved from client to its own file


Playgrounds:
- New SingleMovieIndex playground to create a new environment for testing
- Updated `SingleIndex` with keepZeroFacets
- Updated `MultiIndex` with keepZeroFacets


Co-authored-by: Charlotte Vermandel <[email protected]>

Author: meili-bors[bot]

src/adapter/search-request-adapter/__tests__/facets-distribution-assigns.tests.ts

@@ -1,10 +1,9 @@
 import { adaptSearchParams } from '../search-params-adapter'
-import { MatchingStrategies } from '../../../types'
+import { MatchingStrategies, SearchContext } from '../../../types'
 
-const DEFAULT_CONTEXT = {
+const DEFAULT_CONTEXT: SearchContext = {
   indexUid: 'test',
   pagination: { page: 0, hitsPerPage: 6, finite: false },
-  defaultFacetDistribution: {},
   placeholderSearch: true,
   keepZeroFacets: false,
 }

src/adapter/search-request-adapter/__tests__/filter-cache.tests.ts

@@ -5,7 +5,6 @@ import {
   SearchCacheInterface,
   MeiliSearchParams,
 } from '../../types'
-import { addMissingFacets, extractFacets } from './filters'
 
 /**
  * @param  {ResponseCacher} cache
@@ -42,16 +41,6 @@ export function SearchResolver(
         .index(searchContext.indexUid)
         .search(searchContext.query, searchParams)
 
-      if (searchContext.keepZeroFacets) {
-        const cachedFacets = extractFacets(searchContext, searchParams)
-
-        // Add missing facets back into facetDistribution
-        searchResponse.facetDistribution = addMissingFacets(
-          cachedFacets,
-          searchResponse.facetDistribution
-        )
-      }
-
       // Cache response
       cache.setEntry<MeiliSearchResponse>(key, searchResponse)