Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong meilisearch client being imported in UMD bundle #1331

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Oct 16, 2024

Pull Request

Related issue

Fixes #1330

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 1e7bf78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@meilisearch/instant-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@flevi29 flevi29 added the bug Something isn't working label Oct 16, 2024
@curquiza curquiza self-requested a review October 16, 2024 13:21
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors bot merged commit 682a604 into meilisearch:main Oct 16, 2024
7 checks passed
@flevi29 flevi29 deleted the fix-rollup-umd-bundle branch October 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module build failed: UnhandledSchemeError: Reading from "node:crypto" with nextjs and 0.21.0
2 participants