Skip to content

Commit

Permalink
Merge #1331
Browse files Browse the repository at this point in the history
1331: Fix wrong meilisearch client being imported in UMD bundle r=curquiza a=flevi29

# Pull Request

## Related issue
Fixes #1330 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: F. Levi <[email protected]>
  • Loading branch information
meili-bors[bot] and flevi29 authored Oct 16, 2024
2 parents 5870e0b + 1e7bf78 commit 682a604
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/big-swans-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@meilisearch/instant-meilisearch": patch
---

Fix wrong "meilisearch" client being imported in UMD bundle.
7 changes: 1 addition & 6 deletions packages/instant-meilisearch/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const ROLLUP_OPTIONS = [
// browser-friendly IIFE build
{
input: INPUT, // directory to transpilation of typescript
external: ['cross-fetch', 'cross-fetch/polyfill'],
output: {
name: 'window',
extend: true,
Expand All @@ -55,11 +54,7 @@ const ROLLUP_OPTIONS = [
},
plugins: [
...COMMON_PLUGINS,
nodeResolve({
mainFields: ['jsnext', 'browser', 'main'],
preferBuiltins: true,
browser: true,
}),
nodeResolve({ exportConditions: ['browser'] }),
commonjs(),
babel(),
// json(),
Expand Down

0 comments on commit 682a604

Please sign in to comment.