Skip to content

Removed tag attribute restrictions - #35

Merged
jkuester merged 13 commits into
medic:xlsform_v3.0.1from
Omswastik-11:xlsform_v3.0.1
Aug 26, 2025
Merged

Removed tag attribute restrictions#35
jkuester merged 13 commits into
medic:xlsform_v3.0.1from
Omswastik-11:xlsform_v3.0.1

Conversation

@Omswastik-11

Copy link
Copy Markdown

Closes #22 .

Sucessfully checked the death_report form conversion .

          <patient_age_in_years tag="hidden">0</patient_age_in_years>
          <patient_age_in_months tag="hidden">0</patient_age_in_months>
          <patient_age_in_days tag="hidden"/>
          <patient_uuid tag="hidden"/>
          <patient_id tag="hidden"/>
          <patient_name tag="hidden"/>
          <patient_short_name tag="hidden"/>
          <patient_display_name tag="hidden"/>
          <death_details>
            <date_of_death/>
            <place_of_death/>
            <place_of_death_other/>
            <death_information/>
          </death_details>
          <group_review tag="hidden">
            <submit/>
            <r_summary_details/>
            <c_patient_age/>
            <r_patient_details/>
            <r_death_info/>
            <r_key_instruction/>
            <blank_note/>
            <r_referral/>
            <r_undo/>
          </group_review>
          <data tag="hidden">
            <__date_of_death/>
            <__place_of_death/>
            <__place_of_death_other/>
            <__death_information/>
            <meta tag="hidden">
              <__patient_uuid/>
              <__patient_id/>
              <__household_uuid/>
              <__source/>
              <__source_id/>
            </meta>
          </data>
          <meta tag="hidden">

@Omswastik-11

Omswastik-11 commented Aug 19, 2025

Copy link
Copy Markdown
Author

Hi @jkuester !!

Can you review this ?

It seems the changes I made earlier are still showing for the meta tag == "hidden" attribute tests .

@jkuester
jkuester self-requested a review August 20, 2025 19:18

@jkuester jkuester left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what was up with the diff, but merging in the latest from medic/xlsform_v3.0.1 seems to have everything rendering as expected now.

Functionality works as expected! 👍 Can can just get one unit test check this behavior?

@Omswastik-11
Omswastik-11 requested a review from jkuester August 25, 2025 08:07
@Omswastik-11

Copy link
Copy Markdown
Author

Hi @jkuester !!
I have implemented the Unittests . Kindly check it.

@jkuester jkuester left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good tests. 👍

@jkuester
jkuester merged commit 90dcbd9 into medic:xlsform_v3.0.1 Aug 26, 2025
10 checks passed
jkuester added a commit that referenced this pull request Aug 26, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
jkuester added a commit that referenced this pull request Aug 26, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
jkuester added a commit that referenced this pull request Aug 26, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
Omswastik-11 added a commit to Omswastik-11/pyxform that referenced this pull request Sep 2, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
jkuester added a commit to jkuester/pyxform that referenced this pull request Sep 2, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
jkuester added a commit to jkuester/pyxform that referenced this pull request Sep 4, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
jkuester added a commit to jkuester/pyxform that referenced this pull request Sep 4, 2025
Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants