Skip to content

Removed tag attribute restrictions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkuester merged 13 commits into from
Aug 26, 2025
Merged

Removed tag attribute restrictions #35

Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4b8fd26
added meta tag == hidden feture along with tests
Omswastik-11 Aug 11, 2025
27a99c8
corrected formatting errors
Omswastik-11 Aug 11, 2025
829d57d
Corrected formatting error
Omswastik-11 Aug 11, 2025
6a126ba
Delete tests/test_remove_tag_restriction.py
Omswastik-11 Aug 11, 2025
cb90cc3
corrected the test_meta_tag_hidden test
Omswastik-11 Aug 15, 2025
285433c
removed tag attribute restrictions
Omswastik-11 Aug 19, 2025
2707d34
corrected formatting
Omswastik-11 Aug 19, 2025
c21b0b5
Merge remote-tracking branch 'origin/xlsform_v3.0.1' into fork/Omswas…
jkuester Aug 21, 2025
4a91333
added unit tests for tag restriction removal
Omswastik-11 Aug 23, 2025
7b9a595
corrected formatting
Omswastik-11 Aug 23, 2025
51953cc
added unittest for instance :: tag == 'hidden'
Omswastik-11 Aug 25, 2025
8100197
corrected formatting
Omswastik-11 Aug 25, 2025
c54c6ca
corrected formatting
Omswastik-11 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyxform/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def node(*args, **kwargs) -> DetachableElement:
kwargs -- attributes
returns a xml.dom.minidom.Element
"""
blocked_attributes = {"tag"}
# blocked_attributes = {"tag"}
tag = args[0] if len(args) > 0 else kwargs["tag"]
args = args[1:]
result = DetachableElement(tag)
Expand All @@ -116,7 +116,9 @@ def node(*args, **kwargs) -> DetachableElement:

# Convert the kwargs xml attribute dictionary to a xml.dom.minidom.Element.
for k, v in kwargs.items():
if k in blocked_attributes:
# if k in blocked_attributes:
# continue
if k == "tag" and v == tag:
continue
if k == "toParseString":
if v is True and len(unicode_args) == 1:
Expand Down
Loading