feat: Populate detours list with channels #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahpurcell
requested review from
firestack
and removed request for
a team
firestack
reviewed
Feb 25, 2025
firestack
reviewed
Feb 26, 2025
firestack
requested changes
Feb 26, 2025
hannahpurcell
temporarily deployed
to
dev-green
GitHub Actions
Inactive
hannahpurcell
force-pushed
the
hp/populate-detours-list-with-channels
branch
from
ce7ece5 to
9770dea
Compare
hannahpurcell
temporarily deployed
to
dev-green
GitHub Actions
Inactive
firestack
approved these changes
Feb 27, 2025
* don't try to save snapshot without nearestIntersection present * Update assets/tests/components/detours/diversionPage.saveDetour.test.tsx Co-authored-by: Kayla Firestack <[email protected]> --------- Co-authored-by: Kayla Firestack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana ticket: https://app.asana.com/0/1205385723132845/1208390246838825
In terms of tests, I'm not sure what else to cover? Ideally, I'd like to verify some integration flow -- like activating a detour triggers the channel to be affected -- but I struggled with that.
Known issue: preventing a drafted detour from appearing in the channel and passing through the
handleDraftedfunction before it has all it's returned values (like nearestIntersection). To be discussed in subsequent PR.Also: have confirmed with Brian that the spinner is great!