Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: make use of status field in detour list queries #2961

Merged
merged 6 commits into from
Feb 18, 2025
Merged

tweak: make use of status field in detour list queries #2961

merged 6 commits into from
Feb 18, 2025

Conversation

bfauble
Copy link
Contributor

@bfauble bfauble commented Feb 11, 2025

@bfauble bfauble marked this pull request as ready for review February 11, 2025 22:09
@bfauble bfauble requested a review from a team as a code owner February 11, 2025 22:09
@bfauble bfauble requested review from firestack and removed request for a team February 11, 2025 22:09
@firestack firestack self-requested a review February 18, 2025 16:11
@firestack firestack mentioned this pull request Feb 18, 2025
Merged
@firestack
Copy link
Member

A thought, now that listing detours is 3 separate sequential DB queries, we'll probably want to get #2962 in so that we can parallelize the queries

@bfauble
Copy link
Contributor Author

bfauble commented Feb 18, 2025

A thought, now that listing detours is 3 separate sequential DB queries, we'll probably want to get #2962 in so that we can parallelize the queries

made a small update to make the 3 calls async which should help a little bit but the queries overall are already quite a bit faster even w/o.

@firestack
Copy link
Member

A thought, now that listing detours is 3 separate sequential DB queries, we'll probably want to get #2962 in so that we can parallelize the queries

made a small update to make the 3 calls async which should help a little bit but the queries overall are already quite a bit faster even w/o.

Love it!

firestack
firestack approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@firestack firestack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ceremonial re-approval for new changes]

@bfauble bfauble merged commit 27759f6 into main Feb 18, 2025
15 checks passed
@bfauble bfauble deleted the bf-query-with-status-field branch February 18, 2025 18:55
bfauble added a commit that referenced this pull request Feb 27, 2025
@bfauble
tweak: make use of status field in detour list queries (#2961)
f101c6a 
* make use of status field in detour list queries

* use select_detour_list_info

* remove unused func

* move grouping of detours into controller

* make grouped detours calls async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfauble @firestack