ActionServer: allow direct setting of arm/disarm state and vehicle flight mode #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanreeves
force-pushed
the
feature/public-set-armed
branch
from
afc4a50 to
c6aa3a6
Compare
julianoes
reviewed
Feb 18, 2025
| } | ||
|
|
||
| message SetFlightModeRequest { | ||
| FlightMode flight_mode = 1; |
There was a problem hiding this comment.
Probably needs a docstring.
There was a problem hiding this comment.
Agreed, makes sense. I'll add it right now.
julianoes
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ActionServerimplementation currently only supports updating arm/disarm status and flight mode by receiving MAVLINK messages from a client. An autopilot implementation may need to take autonomous action to change flight modes or report an armed status apart from explicit GCS command. This PR provides the necessary support to do that.