-
Notifications
You must be signed in to change notification settings - Fork 285
Upgrade http, ruma, reqwest and wiremock dependencies #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They need to be updated together because the latters depend on the former. matrix-authentication-service is still using http 0.2 so we need to add a conversion layer between both major versions for OIDC requests. We need to update vodozemac too because of a dependency resolution issue. Signed-off-by: Kévin Commaille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer that we'd wait for the matrix-authentication-service crate to update its HTTP crate instead of adding all the HttpOld/HttpNew conversation stuff.
Out of curiosity: are you making this PR because you require it for some reasons, or is it only careful maintenance? (in any case, thanks for opening such a PR!)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3362 +/- ##
==========================================
- Coverage 83.62% 83.49% -0.14%
==========================================
Files 242 243 +1
Lines 25009 25052 +43
==========================================
+ Hits 20915 20916 +1
- Misses 4094 4136 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's a nice step forward as it removes a bunch of duplicated crates in the dependency tree, and we can easily get rid of the http_old conversion code later on. Thanks!
For reference, I looked into updating MAS itself, but it's blocked by open-telemetry/opentelemetry-rust#1674 getting merged and released. |
No we don't require it for the moment, I just knew it was probably going to be a big change, so I wanted to get a head start.
Yeah we have been waiting a bit to update http in Ruma so we could avoid the conversion layer for the SDK, but we would like to make a new release soon and we wanted to upgrade http before it. |
Signed-off-by: Kévin Commaille <[email protected]>
Merged main branch to resolve conflict |
They need to be updated together because the latters depend on the former.
matrix-authentication-service is still using http 0.2 so we need to add a conversion layer between both major versions for OIDC requests for now.
We need to update vodozemac too because of a dependency resolution issue.