-
Notifications
You must be signed in to change notification settings - Fork 285
oidc: Use the correct types to compare the status codes in the oidc example #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 243 243
Lines 25052 25052
=======================================
Hits 20914 20914
Misses 4138 4138 ☔ View full report in Codecov by Sentry. |
I believe this should not be necessary if #3362 is merged. |
Actually, we could fully qualify |
You mean post merge or in this PR? |
In this PR, that should work at any time. Actually the best option would probably be to not depend directly on http, but use |
Right: 344c77b |
344c77b
to
ed8c7f1
Compare
Something went wrong while #3305 was merged. This fixes the issue introduced by the github rebase.