Skip to content

Solution #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nykyforov-dan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #4060

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0107e8e
Solution
nykyforov-dan Jan 6, 2026
5dd1b57
Solution change
nykyforov-dan Jan 6, 2026
1120f8c
Solution change
nykyforov-dan Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import React from 'react';
import { Sum } from './components/Sum/Sum';
import './App.scss';

export const App = () => (
<>
<p>Sum of 2 and 3 is 5</p>
<p>Sum of -5 and 5 is 0</p>
<p>Sum of 10 and 0 is 10</p>
<p>Sum of 0 and 5 is 5</p>
<p>Sum of 0 and 0 is 0</p>
{/* Replace paragraphs with Sum componets */}
{/* And remove commented lines :) */}
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} b={0} />
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement is to render a Sum component with just a = 10. You should omit the b prop and let the Sum component use its default value.

<Sum a={0} b={5} />
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the task description, this Sum component should be rendered with just b = 5. The a prop should not be passed, allowing the default prop value to be used.

<Sum a={0} b={0} />
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Sum component should be rendered with 'no params at all'. Instead of explicitly passing 0 for a and b, you should remove the props entirely.

</>
);
6 changes: 5 additions & 1 deletion src/components/Sum/Sum.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside tag content'. While your code works, the good example in the checklist suggests using a single template literal for better readability, like {Sum of ${a} and ${b} is ${a + b}}.

</p>
);