-
Notifications
You must be signed in to change notification settings - Fork 1.8k
add solution #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add solution #1778
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing required implementation: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing required implementation: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing required implementation: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing required implementation: |
||
| Navigate, | ||
| Route, | ||
| HashRouter as Router, | ||
| Routes, | ||
| } from 'react-router-dom'; | ||
| import { App } from './App'; | ||
| import React from 'react'; | ||
| import { NotFoundPage } from './components/NotFoundPage'; | ||
| import { HomePage } from './components/HomePage'; | ||
| import { PeoplePage } from './components/PeoplePage'; | ||
|
|
||
| export const Root = () => { | ||
| return ( | ||
| <Router> | ||
| <Routes> | ||
| <Route path="/" element={<App />}> | ||
| <Route path="*" element={<NotFoundPage />}></Route> | ||
|
|
||
| <Route index element={<HomePage />} /> | ||
| <Route path="/home" element={<Navigate to="/" replace />} /> | ||
| <Route path="people/"> | ||
| <Route index element={<PeoplePage />} /> | ||
| <Route path=":slug" element={<PeoplePage />} /> | ||
| </Route> | ||
| </Route> | ||
| </Routes> | ||
| </Router> | ||
| ); | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import React from 'react'; | ||
|
|
||
| export const HomePage = () => <h1 className="title">Home Page</h1>; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import React from 'react'; | ||
|
|
||
| export const NotFoundPage = () => <h1 className="title">Page not found</h1>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required implementation:
PeopleFilters.tsx- must implement NameFilter (query param), CenturyFilter (centuries param with append/getAll), and SexFilter (sex param) according to requirements.