Skip to content

add solution#1778

Open
Sviatoslav593 wants to merge 1 commit into
mate-academy:masterfrom
Sviatoslav593:develop
Open

add solution#1778
Sviatoslav593 wants to merge 1 commit into
mate-academy:masterfrom
Sviatoslav593:develop

Conversation

@Sviatoslav593
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully fulfills all core requirements for the React People Table filtering and sorting task. The code correctly implements URL search params persistence for all filters (name with query param, sex with sex param, centuries with append/getAll methods) and sorting (name, sex, born, died with three-click toggle cycle: ascending → descending → disabled). The PersonLink.tsx properly preserves search params when navigating to person details using useLocation().search, and SearchLink.tsx correctly implements the utility component using getSearchWith. The sidebar visibility is properly gated on the loading state, and all sorting logic handles both string and numeric fields appropriately. The implementations follow React Router patterns, maintain clean component responsibilities, and provide a working demo at the provided GitHub Pages link. No critical blockers were identified.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/Root.tsx
@@ -0,0 +1,30 @@
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required implementation: PeopleFilters.tsx - must implement NameFilter (query param), CenturyFilter (centuries param with append/getAll), and SexFilter (sex param) according to requirements.

Comment thread src/Root.tsx
@@ -0,0 +1,30 @@
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required implementation: PeoplePage.tsx - must implement filtering logic (name, sex, centuries), sorting by name/sex/born/died, and URL search params persistence.

Comment thread src/Root.tsx
@@ -0,0 +1,30 @@
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required implementation: PeopleTable.tsx - must implement sortable table headers with sort/order params, ascending/descending/disabled toggle cycle, and filter visibility only when people are loaded.

Comment thread src/Root.tsx
@@ -0,0 +1,30 @@
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required implementation: PersonLink.tsx - must maintain search params when navigating to person details (preserve filters/sort on click).

Comment thread src/Root.tsx
@@ -0,0 +1,30 @@
import {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required implementation: SearchLink.tsx - utility component for updating URL search params that must be used throughout the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants