Skip to content

add task solution #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timurradkevic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

> Here is the [working version](https://mate-academy.github.io/react_pagination/)

You a given a list of items and markup for the `Pagination`. Implement the
You a given a list of items and markup for the `Pagination`. Implement the
`Pagination` as a stateless component to show only the items for a current page.

1. The `Pagination` should be used with the next props:
Expand Down Expand Up @@ -32,4 +32,4 @@ You a given a list of items and markup for the `Pagination`. Implement the
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_pagination/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://timurradkevic.github.io/react_pagination/) and add it to the PR description.
104 changes: 33 additions & 71 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,40 @@
import React from 'react';
import React, { ChangeEvent, useState } from 'react';
import './App.css';
import { getNumbers } from './utils';
import { Pagination } from './components/Pagination';

// eslint-disable-next-line @typescript-eslint/no-unused-vars
const items = getNumbers(1, 42).map(n => `Item ${n}`);

export const App: React.FC = () => {
const total = 42;
const [perPage, setPerPage] = useState(5);
const [currentPage, setCurrentPage] = useState(1);
const start = (currentPage - 1) * perPage;
const end = currentPage * perPage > total ? total : currentPage * perPage;

const handleChangePerPage = (event: ChangeEvent<HTMLSelectElement>) => {
setPerPage(+event.target.value);
setCurrentPage(1);
};

return (
<div className="container">
<h1>Items with Pagination</h1>

<p className="lead" data-cy="info">
Page 1 (items 1 - 5 of 42)
Page {currentPage} (items {start + 1} - {end} of 42)
</p>

<div className="form-group row">
<div className="col-3 col-sm-2 col-xl-1">
<select
data-cy="perPageSelector"
id="perPageSelector"
className="form-control">
className="form-control"
value={perPage}
onChange={handleChangePerPage}
>
<option value="3">3</option>
<option value="5">5</option>
<option value="10">10</option>
Expand All @@ -32,78 +47,25 @@ export const App: React.FC = () => {
</label>
</div>

{/* Move this markup to Pagination */}
<ul className="pagination">
<li className="page-item disabled">
<a
data-cy="prevLink"
className="page-link"
href="#prev"
aria-disabled="true">
«
</a>
</li>
<li className="page-item active">
<a data-cy="pageLink" className="page-link" href="#1">
1
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#2">
2
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#3">
3
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#4">
4
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#5">
5
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#6">
6
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#7">
7
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#8">
8
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#9">
9
</a>
</li>
<li className="page-item">
<a
data-cy="nextLink"
className="page-link"
href="#next"
aria-disabled="false">
»
</a>
</li>
</ul>
<Pagination
total={total}
perPage={perPage}
currentPage={currentPage}
onPageChange={page => {
setCurrentPage(page);
}}
/>
<ul>
<li data-cy="item">Item 1</li>
{items.slice(start, end).map(item => (
<li data-cy="item" key={item}>
{item}
</li>
))}
{/* <li data-cy="item">Item 1</li>
<li data-cy="item">Item 2</li>
<li data-cy="item">Item 3</li>
<li data-cy="item">Item 4</li>
<li data-cy="item">Item 5</li>
<li data-cy="item">Item 5</li> */}
</ul>
</div>
);
Expand Down
128 changes: 127 additions & 1 deletion src/components/Pagination/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,127 @@
export const Pagination = () => {};
import React from 'react';
import { getNumbers } from '../../utils';

interface Props {
total: number;
perPage: number;
currentPage: number;
onPageChange: (page: number) => void;
}

export const Pagination: React.FC<Props> = ({
total,
perPage,
currentPage,
onPageChange,
}) => {
const pageLinkTotal = getNumbers(1, Math.ceil(total / perPage));
const maxPage = pageLinkTotal[pageLinkTotal.length - 1];

return (
<ul className="pagination">
<li className={currentPage === 1 ? 'page-item disabled' : 'page-item'}>
<a
data-cy="prevLink"
className="page-link"
href="#prev"
aria-disabled={currentPage === 1 ? 'true' : 'false'}
onClick={event => {
event.preventDefault();
if (currentPage === 1) {
return;
}

onPageChange(currentPage - 1);
}}
Comment on lines +28 to +35
Copy link
Copy Markdown

@ArturErmolenko ArturErmolenko Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to handler

>
«
</a>
</li>
{pageLinkTotal.map(pageLink => (
<li
className={
currentPage === pageLink ? 'page-item active' : 'page-item'
}
key={pageLink}
>
<a
data-cy="pageLink"
className="page-link"
href={`#${pageLink}`}
onClick={event => {
event.preventDefault();
onPageChange(pageLink);
}}
>
{pageLink}
</a>
</li>
))}
Comment on lines +41 to +59
Copy link
Copy Markdown

@ArturErmolenko ArturErmolenko Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like component

{/* <li className="page-item active">
<a data-cy="pageLink" className="page-link" href="#1">
1
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#2">
2
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#3">
3
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#4">
4
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#5">
5
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#6">
6
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#7">
7
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#8">
8
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#9">
9
</a>
</li> */}
Comment on lines +60 to +104
Copy link
Copy Markdown

@ArturErmolenko ArturErmolenko Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

<li
className={currentPage === maxPage ? 'page-item disabled' : 'page-item'}
Copy link
Copy Markdown

@ArturErmolenko ArturErmolenko Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use classname lib

>
<a
data-cy="nextLink"
className="page-link"
href="#next"
aria-disabled={currentPage === maxPage ? 'true' : 'false'}
onClick={event => {
event.preventDefault();
if (currentPage === maxPage) {
return;
}

onPageChange(currentPage + 1);
}}
>
»
</a>
</li>
</ul>
);
};
Loading