Skip to content

add task solution#1490

Open
timurradkevic wants to merge 1 commit into
mate-academy:masterfrom
timurradkevic:develop
Open

add task solution#1490
timurradkevic wants to merge 1 commit into
mate-academy:masterfrom
timurradkevic:develop

Conversation

@timurradkevic
Copy link
Copy Markdown

Comment on lines +28 to +35
onClick={event => {
event.preventDefault();
if (currentPage === 1) {
return;
}

onPageChange(currentPage - 1);
}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to handler

Comment on lines +60 to +104
{/* <li className="page-item active">
<a data-cy="pageLink" className="page-link" href="#1">
1
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#2">
2
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#3">
3
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#4">
4
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#5">
5
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#6">
6
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#7">
7
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#8">
8
</a>
</li>
<li className="page-item">
<a data-cy="pageLink" className="page-link" href="#9">
9
</a>
</li> */}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

</a>
</li> */}
<li
className={currentPage === maxPage ? 'page-item disabled' : 'page-item'}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use classname lib

Comment on lines +41 to +59
<li
className={
currentPage === pageLink ? 'page-item active' : 'page-item'
}
key={pageLink}
>
<a
data-cy="pageLink"
className="page-link"
href={`#${pageLink}`}
onClick={event => {
event.preventDefault();
onPageChange(pageLink);
}}
>
{pageLink}
</a>
</li>
))}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants