Skip to content

m #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoraEmpty wants to merge 4 commits into
base: master
Choose a base branch
from
Open

m #214

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2e3edf
m
SoraEmpty May 16, 2026
c00b18f
m
SoraEmpty May 16, 2026
a7e450c
messages
SoraEmpty May 16, 2026
e1a76f5
small changes
SoraEmpty May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .eslintrc.js → .eslintrc.cjs
View file
Open in desktop
File renamed without changes.
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
24 changes: 24 additions & 0 deletions chat/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
pnpm-debug.log*
lerna-debug.log*

node_modules
dist
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and the entire chat/src/ directory are unused boilerplate. The actual app uses the root index.html which references /src/frontend/src/index.tsx. Consider removing this duplicate Vite setup.

dist-ssr
*.local

# Editor directories and files
.vscode/*
!.vscode/extensions.json
.idea
.DS_Store
*.suo
*.ntvs*
*.njsproj
*.sln
*.sw?
73 changes: 73 additions & 0 deletions chat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
# React + TypeScript + Vite

This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.

Currently, two official plugins are available:

- [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react) uses [Oxc](https://oxc.rs)
- [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react-swc) uses [SWC](https://swc.rs/)

## React Compiler

The React Compiler is not enabled on this template because of its impact on dev & build performances. To add it, see [this documentation](https://react.dev/learn/react-compiler/installation).

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src/frontend/ directory lacks package.json, tsconfig.json, and vite.config.ts files needed to build the React frontend. Without these, the frontend cannot be built or run.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server CORS is configured for http://localhost:5173, but if the frontend were in chat/, Vite would run on a different port. Verify the frontend dev server port matches the CORS origin.

## Expanding the ESLint configuration
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing implementation: The task requires a React client with username input saved to localStorage, room management UI, and message display with author/time/text. The main App.tsx file is not present.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing implementation: The task requires type definitions for Message (with author, time, text), Room, and possibly User. The types.ts file is not present.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing implementation: The task requires client-side styling for the chat interface. The App.scss file is not present.


If you are developing a production application, we recommend updating the configuration to enable type-aware lint rules:

```js
export default defineConfig([
globalIgnores(['dist']),
{
files: ['**/*.{ts,tsx}'],
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chat/ directory contains complete Vite configuration files (vite.config.ts, tsconfig.*.json, eslint.config.js) and template files (App.tsx, main.tsx) that are never used - the root index.html points to src/frontend/src/index.tsx instead. This creates confusion about the project structure and wastes space.

extends: [
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing implementation: The task requires a Node.js server (src/index.js) with Socket.IO for handling rooms, messages, and real-time communication. This file is not present.

// Other configs...

// Remove tseslint.configs.recommended and replace with this
tseslint.configs.recommendedTypeChecked,
// Alternatively, use this for stricter rules
tseslint.configs.strictTypeChecked,
// Optionally, add this for stylistic rules
tseslint.configs.stylisticTypeChecked,

// Other configs...
],
languageOptions: {
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
tsconfigRootDir: import.meta.dirname,
},
// other options...
},
},
])
```

You can also install [eslint-plugin-react-x](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-x) and [eslint-plugin-react-dom](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-dom) for React-specific lint rules:

```js
// eslint.config.js
import reactX from 'eslint-plugin-react-x'
import reactDom from 'eslint-plugin-react-dom'

export default defineConfig([
globalIgnores(['dist']),
{
files: ['**/*.{ts,tsx}'],
extends: [
// Other configs...
// Enable lint rules for React
reactX.configs['recommended-typescript'],
// Enable lint rules for React DOM
reactDom.configs.recommended,
],
languageOptions: {
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
tsconfigRootDir: import.meta.dirname,
},
// other options...
},
},
])
```
22 changes: 22 additions & 0 deletions chat/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import js from '@eslint/js'
import globals from 'globals'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'
import tseslint from 'typescript-eslint'
import { defineConfig, globalIgnores } from 'eslint/config'

export default defineConfig([
globalIgnores(['dist']),
{
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default Vite entry point template. Does not implement the required chat application setup.

files: ['**/*.{ts,tsx}'],
extends: [
js.configs.recommended,
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default Vite HTML template pointing to /src/main.tsx. Does not reference any chat implementation.

tseslint.configs.recommended,
reactHooks.configs.flat.recommended,
reactRefresh.configs.vite,
],
languageOptions: {
globals: globals.browser,
},
},
])
13 changes: 13 additions & 0 deletions chat/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend application uses react-router-dom (HashRouter) and socket.io-client, but no package.json was provided showing these dependencies. Ensure all required packages are installed.

<title>chat</title>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The server file uses express, socket.io, and cors packages but no package.json was provided showing these as dependencies in the server directory.

</head>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chat/src/main.tsx file still contains the default Vite template code. It imports from './App.tsx' which also has default template content. The actual chat application exists in src/frontend/src/ but is not connected to this Vite project entry point.

<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html>
Loading
Loading