Skip to content

m #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoraEmpty wants to merge 4 commits into
base: master
Choose a base branch
from
Open

m #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2e3edf
m
SoraEmpty May 16, 2026
c00b18f
m
SoraEmpty May 16, 2026
a7e450c
messages
SoraEmpty May 16, 2026
e1a76f5
small changes
SoraEmpty May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .eslintrc.js → .eslintrc.cjs
View file
Open in desktop
File renamed without changes.
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
6 changes: 6 additions & 0 deletions declarations.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
declare module "*.scss" {
const content: { [className: string]: string };
export default content;
Comment on lines +1 to +3
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The User type is imported but never used in the component. The app uses string username directly rather than a User object. Consider removing the unused import or using the User type if needed.

}

Comment on lines +4 to +5
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The // @ts-ignore comment bypasses TypeScript checking for the SCSS import. While a type declaration exists in declarations.d.ts, the import might not be recognized. Consider using import styles from './App.scss' and ensuring the declaration file is properly included in tsconfig.

declare module "*.css";
13 changes: 13 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/png" href="img/favicon.png"/>
Comment on lines +1 to +5
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The User type is defined in types.ts but is never imported or used in App.tsx. This is dead code that can be removed to improve code cleanliness.

Comment on lines +4 to +5
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using // @ts-ignore to suppress SCSS module type errors. Consider adding proper type declarations instead: declare module '*.scss' { const content: Record<string, string>; export default content; }

Comment on lines +4 to +5
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The // @ts-ignore comment on line 4 indicates TypeScript isn't properly configured to handle SCSS imports. Consider moving declarations.d.ts into src/frontend/ and adding proper tsconfig.json configuration instead of suppressing the warning.

<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Chat</title>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/frontend/src/index.tsx"></script>
</body>
</html>
Loading
Loading