Skip to content

add task solution #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spojrzenie wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
511cff1
add task solution
spojrzenie Apr 26, 2023
0133691
Change title and add h1 paragraph
spojrzenie Apr 26, 2023
a2f7527
Change site title
spojrzenie Apr 26, 2023
f0418c0
Fix errors like missing colon, etc
spojrzenie Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# HTML form
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_html-form/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_html-form/report/html_report/)
- [DEMO LINK](https://spojrzenie.github.io/layout_html-form/)
- [TEST REPORT LINK](https://spojrzenie.github.io/layout_html-form/report/html_report/)

> Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/#how-to-solve-the-layout-tasks-on-github)
___
Expand Down
185 changes: 184 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,190 @@
<link rel="stylesheet" href="./style.css">
</head>
<body>
<h1>HTML Form</h1>
<script type="text/javascript" src="./main.js"></script>

<form
action="https://mate-academy-form-lesson.herokuapp.com/create-application"
method="post">

<fieldset class="form-fieldset">
<legend>Personal information</legend>

<div class="form-field">
<label for="surname">Surname:</label>
<input
type="text"
id="surname"
name="surname"
required
autocomplete="off"
>
</div>

<div class="form-field">
<label for="name">Name:</label>
<input
type="text"
id="name"
name="name"
minlength="3"
maxlength="50"
autocomplete="off"
>
</div>

<div class="form-field">
<label for="age">How old are you?</label>
<input
type="number"
id="age"
name="age"
value="12"
max="100"
min="1"
>
</div>

<div class="form-field">
<label for="birthday">Full date of birth:</label>
<input
type="date"
id="birthday"
name="birthday"
>
</div>

<div class="form-field">
<label for="agreement">
I accept the term of the agreement
</label>
<input
type="checkbox"
id="agreement"
name="agreement"
>
</div>
</fieldset>


<fieldset class="form-fieldset">
<legend>Registration</legend>

<div class="form-field">
<label for="email">E-mail:</label>
<input
type="email"
id="email"
name="email"
placeholder="[email protected]"
>
</div>

<div class="form-field">
<label for="password">Password:</label>
<input
type="password"
id="password"
name="password"
max="20"
min="8"
>
Copy link
Copy Markdown

@darokrk darokrk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minlength and maxlength attributes for the password input to define password strength requirements.

</div>
</fieldset>

<fieldset class="form-fieldset">
<legend>An interesting fact about you!</legend>

<div class="form-field">
Do you love cats?
<input
type="radio"
value="yes"
id="yesCats"
name="loveCats"
>
<label for="yesCats">Yes</label>

<input
type="radio"
value="no"
id="noCats"
name="loveCats"
>
<label for="noCats">No</label>

</div>

<div class="form-field">
<label for="color">What is your favorite color?</label>
<input
type="color"
id="color"
name="favColor"
>
</div>

<div class="form-field">
<label for="bedTime">What time do you go to bed?</label>
<input
Copy link
Copy Markdown

@darokrk darokrk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add step="2" attribute to have seconds values

type="time"
id="bedTime"
name="bedTime"
step="2"
>
</div>

<div class="form-field">
<label for="cars">What are your favorite brand of cars?</label>
<select
name="favCars"
id="cars"
multiple
>
<option value="bmw">BMW</option>
<option value="audi">Audi</option>
<option value="lada">Lada</option>

</select>
</div>

<div class="form-field">
<label for="rate">How do you rate our work?</label>
<input
id="rate"
name="work"
type="range"
min="0"
max="11"
>
</div>
</fieldset>

<fieldset class="form-fieldset">
<legend>Additional info:</legend>
<div class="form-field">
<label for="comments">Comments:</label>
<textarea
name="comments"
id="comments"
cols="25"
rows="2"
></textarea>
</div>

<div class="form-field">
<label for="recommend">Would you recommend us?</label>
<select name="recommend" id="recommend">
<option value="yes">Yes</option>
<option value="no">No</option>
</select>
</div>
</fieldset>

<div class="form-field">
Copy link
Copy Markdown

@darokrk darokrk Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this button to be grouped in this div?

<button type="submit">Submit</button>
</div>

</form>
</body>
</html>
11 changes: 11 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,12 @@
/* styles go here */
.form-field {
margin-bottom: 10px;
}

.form-fieldset {
margin-bottom: 20px;
}

fieldset .form-field:last-child {
margin-bottom: 0;
}