add task solution#784
Conversation
darokrk
left a comment
darokrk
left a comment
There was a problem hiding this comment.
Good job, some small shortcomings to improve and it should be ok 👍🏽
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| /* Usuń margines dolny dla ostatniego .form-field wewnątrz fieldset */ |
There was a problem hiding this comment.
Please change the comment to English, for better understanding and consistency or remove it
| type="password" | ||
| id="password" | ||
| name="password" | ||
| > |
There was a problem hiding this comment.
Add minlength and maxlength attributes for the password input to define password strength requirements.
| <input | ||
| type="color" | ||
| id="color" | ||
| name="fav-color" |
There was a problem hiding this comment.
if we follow camelCase convention like you named loveCats this should be name="favColor" also for bedtime & favcars etc.
| margin-bottom: 10px; | ||
| } | ||
|
|
||
| fieldset { |
There was a problem hiding this comment.
don't style elements by tag, rather use some class name here like .form-fieldset
| name="comments" | ||
| id="comments" | ||
| cols="30" | ||
| rows="10" |
There was a problem hiding this comment.
Think you rows value here is to big, it should be rather 3
| id="cars" | ||
| multiple | ||
| > | ||
| <option value="audi">Audi</option> |
There was a problem hiding this comment.
try options input here like:
BMW
Audi
Lada
|
|
||
| <div class="form-field"> | ||
| <label for="bedTime">What time do you go to bed?</label> | ||
| <input |
There was a problem hiding this comment.
add step="2" attribute to have seconds values
| <legend>Personal information</legend> | ||
|
|
||
| <div class="form-field"> | ||
| <label for="surname">Surname</label> |
There was a problem hiding this comment.
You missed colon for each label in your file, please add : e.g. Surname:
| </div> | ||
| </fieldset> | ||
|
|
||
| <div class="form-field"> |
There was a problem hiding this comment.
do we need this button to be grouped in this div?
Thank you, i'll fix it later. |
|
Ok, i think i fixed everything. Can you accept my changes so I can move on? |
|
Should i click button "Close with comment"? |
darokrk
left a comment
darokrk
left a comment
There was a problem hiding this comment.
Task approved! Nicely done, good job 🥇
Yes you did it correctly :) |
2 participants
No description provided.