Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<maven.checkstyle.plugin.version>3.1.1</maven.checkstyle.plugin.version>
<maven.checkstyle.plugin.configLocation>
<!-- google_checks.xml-->
https://raw.githubusercontent.com/mate-academy/style-guides/master/java/checkstyle.xml
</maven.checkstyle.plugin.configLocation>
</properties>
Expand Down
1 change: 1 addition & 0 deletions src/main/java/mate/academy/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import mate.academy.service.AuthenticationService;

public class Main {

private static final AuthenticationService authenticationService = new AuthenticationService();

public static void main(String[] args) {
Expand Down
1 change: 1 addition & 0 deletions src/main/java/mate/academy/model/User.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package mate.academy.model;

public class User {

private String email;
private String password;

Expand Down
21 changes: 14 additions & 7 deletions src/main/java/mate/academy/service/AuthenticationService.java
Original file line number Diff line number Diff line change
@@ -1,16 +1,23 @@
package mate.academy.service;

import mate.academy.model.User;

public class AuthenticationService {

/**
* Imagine that some user wants to login to your site.
* You should check if user credentials (login and password) are valid or not.
* All users are stored in <code>UserService</code> class.
* @param email - user's email
* Imagine that some user wants to login to your site. You should check if user credentials

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes

* (login and password) are valid or not. All users are stored in <code>UserService</code>
* class.
*
* @param email - user's email
* @param password - user's password
* @return true if user by email exists and passed password is equal to user's password.
* Return false in any other cases.
* @return true if user by email exists and passed password is equal to user's password. Return
* false in any other cases.
*/
public boolean login(String email, String password) {
return false;
UserService userService = new UserService();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make UserService userService class-level variable

User user = userService.findByEmail(email);
return user != null && user.getPassword().equals(password);
}
}

18 changes: 12 additions & 6 deletions src/main/java/mate/academy/service/UserService.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,24 @@
import mate.academy.model.User;

public class UserService {
private static final User[] users = new User[] {
new User("[email protected]", "1234"),
new User("[email protected]", "1234")
};

private static final User[] users = new User[]{new User("[email protected]", "1234"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes

new User("[email protected]", "1234")};

/**
* Find user by email. All users are stored in <code>private static final User[] users</code>
*
* @param email - the input parameter
* @return - user if his email is equal to passed email.
* Return <code>null</code> if there is no suitable user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change docs, revert changes

* @return - user if his email is equal to passed email. Return <code>null</code> if there is no
* suitable user
*/

public User findByEmail(String email) {
for (User user : users) {
if (user.getEmail().equals(email)) {
return user;
}
}
return null;
}
}