implemented a login method #1249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Aug 27, 2025
Elena-Bruyako
left a comment
Elena-Bruyako
left a comment
There was a problem hiding this comment.
Good job!
let's fix some comments
Do not change java doc
| */ | ||
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); |
There was a problem hiding this comment.
let's make UserService userService class-level variable
| * | ||
| * @param email - the input parameter | ||
| * @return - user if his email is equal to passed email. | ||
| * Return <code>null</code> if there is no suitable user |
There was a problem hiding this comment.
don't change docs, revert changes
| new User("[email protected]", "1234") | ||
| }; | ||
|
|
||
| private static final User[] users = new User[]{new User("[email protected]", "1234"), |
| * You should check if user credentials (login and password) are valid or not. | ||
| * All users are stored in <code>UserService</code> class. | ||
| * @param email - user's email | ||
| * Imagine that some user wants to login to your site. You should check if user credentials |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.