Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/core/basesyntax/Calculation.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package core.basesyntax;

public interface Calculation {
double calculate(double number1, double number2, char operation);
}
21 changes: 21 additions & 0 deletions src/main/java/core/basesyntax/Calculator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package core.basesyntax;

public class Calculator implements Calculation {
@Override
public double calculate(double number1, double number2, char operation) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

плохая практика использовать числа в названии переменных и аргументов

switch (operation) {
case '+':
return number1 + number2;
case '-':
return number1 - number2;
case '*':
return number1 * number2;
case '/':
return number1 / number2;
case '^':
return Math.pow(number1, number2);
default:
throw new IllegalOperationException("Illegal operator");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new IllegalOperationException("Illegal operator");
throw new IllegalOperationException("Illegal operator " + operation);

лучше делать сообщение ошибок как можно более информативными

}
}
}
8 changes: 0 additions & 8 deletions src/main/java/core/basesyntax/HelloWorld.java

This file was deleted.

7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/IllegalOperationException.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

public class IllegalOperationException extends RuntimeException {
public IllegalOperationException(String message) {
super(message);
}
}
212 changes: 212 additions & 0 deletions src/test/java/core/basesyntax/CalculatorTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,212 @@
package core.basesyntax;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

class CalculatorTest {
private static final double DELTA = 0.1;
private static Calculation count;
private double actual;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

цю змінну нема сенсу виносити на рівень класу, вона для усіх методів повинна відрізнятись


@BeforeAll
public static void beforeAll() {
count = new Calculator();
}

@Test
public void calculate_addition_positiveOperands() {
actual = count.calculate(6, 7, '+');
assertEquals(13, actual);
}

@Test
public void calculate_addition_negativeOperands() {
actual = count.calculate(-9, -11, '+');
assertEquals(-20, actual);
}

@Test
public void calculate_addition_positiveNegativeOperands() {
actual = count.calculate(10, -20, '+');
assertEquals(-10, actual);
}

@Test
public void calculate_addition_zeroOperands() {
actual = count.calculate(0, 0, '+');
assertEquals(0, actual);
}

@Test
public void calculate_addition_operandsMinValues() {
actual = count.calculate(Double.MIN_VALUE, Double.MIN_VALUE, '+');
assertEquals(1.0E-323, actual);
}

@Test
public void calculate_addition_operandsMaxValues() {
actual = count.calculate(Double.MAX_VALUE, Double.MAX_VALUE, '+');
assertTrue(Double.isInfinite(actual));
}

@Test
public void calculate_subtraction_positiveOperands() {
actual = count.calculate(6, 7, '-');
assertEquals(-1, actual);
}

@Test
public void calculate_subtraction_negativeOperands() {
actual = count.calculate(-9, -11, '-');
assertEquals(2, actual);
}

@Test
public void calculate_subtraction_positiveNegativeOperands() {
actual = count.calculate(10, -20, '-');
assertEquals(30, actual);
}

@Test
public void calculate_subtraction_zeroOperands() {
actual = count.calculate(0, 0, '-');
assertEquals(0, actual);
}

@Test
public void calculate_subtraction_operandsMinValues() {
actual = count.calculate(Double.MIN_VALUE, Double.MIN_VALUE, '-');
assertEquals(0, actual);
}

@Test
public void calculate_subtraction_operandsMaxValues() {
actual = count.calculate(Double.MAX_VALUE, Double.MAX_VALUE, '-');
assertEquals(0, actual);
}

@Test
public void calculate_multiplication_positiveOperands() {
actual = count.calculate(6, 7, '*');
assertEquals(42, actual);
}

@Test
public void calculate_multiplication_negativeOperands() {
actual = count.calculate(-9, -11, '*');
assertEquals(99, actual);
}

@Test
public void calculate_multiplication_positiveNegativeOperands() {
actual = count.calculate(10, -20, '*');
assertEquals(-200, actual);
}

@Test
public void calculate_multiplication_zeroOperands() {
actual = count.calculate(0, 2, '*');
assertEquals(0, actual);
actual = count.calculate(2, 0, '*');
assertEquals(0, actual);
actual = count.calculate(0, 0, '*');
assertEquals(0, actual);
}

@Test
public void calculate_multiplication_operandsMinValues() {
actual = count.calculate(Double.MIN_VALUE, Double.MIN_VALUE, '*');
assertEquals(0, actual);
}

@Test
public void calculate_multiplication_operandsMaxValues() {
actual = count.calculate(Double.MAX_VALUE, Double.MAX_VALUE, '*');
assertTrue(Double.isInfinite(actual));
}

@Test
public void calculate_division_positiveOperands() {
actual = count.calculate(1.4, 1.2, '/');
assertEquals(1.2, actual, DELTA);
}

@Test
public void calculate_division_negativeOperands() {
actual = count.calculate(-10, -2, '/');
assertEquals(5, actual);
}

@Test
public void calculate_division_positiveNegativeOperands() {
actual = count.calculate(10, -2, '/');
assertEquals(-5, actual);
}

@Test
public void calculate_division_zeroDividendOperand() {
actual = count.calculate(0, 5, '/');
assertEquals(0, actual);
}

@Test
public void calculate_division_zeroDividerOperand() {
actual = count.calculate(5, 0, '/');
assertTrue(Double.isInfinite(actual));
}

@Test
public void calculate_division_operandsMinValues() {
actual = count.calculate(Double.MIN_VALUE, Double.MIN_VALUE, '/');
assertEquals(1, actual);
}

@Test
public void calculate_division_operandsMaxValues() {
actual = count.calculate(Double.MAX_VALUE, Double.MAX_VALUE, '/');
assertEquals(1, actual);
}

@Test
void calculate_raising_positiveNegativeValue_positivePower() {
actual = count.calculate(2, 3, '^');
assertEquals(8, actual);
actual = count.calculate(-2, 3, '^');
assertEquals(-8, actual);
}

@Test
void calculate_raising_positiveNegativeValue_negativePower() {
actual = count.calculate(2, -2, '^');
assertEquals(0.25, actual);
actual = count.calculate(-2, -2, '^');
assertEquals(0.25, actual);
}

@Test
void calculate_raising_positiveNegativeValue_zeroPower() {
actual = count.calculate(2, 0, '^');
assertEquals(1, actual);
actual = count.calculate(-2, 0, '^');
assertEquals(1, actual);
}

@Test
void calculate_raising_zeroValue_positiveNegativePower() {
actual = count.calculate(0, -2, '^');
assertTrue(Double.isInfinite(actual));
actual = count.calculate(0, 2, '^');
assertEquals(0, actual);
}

@Test
void calculate_illegalOperation_isNotOk() {
assertThrows(IllegalOperationException.class, () -> {
count.calculate(0, 2, '%');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
count.calculate(0, 2, '%');
count.calculate(0, 2, invalidOperation);

для читаймості краще цей чар оголосити змінною в методі

});
}
}
8 changes: 0 additions & 8 deletions src/test/java/core/basesyntax/HelloWorldTest.java

This file was deleted.