implemented task lambda calc#304
Open
alex-hazniuk wants to merge 2 commits into
Open
Conversation
RomanDubovskyi
suggested changes
Oct 22, 2021
| class CalculatorTest { | ||
| private static final double DELTA = 0.1; | ||
| private static Calculation count; | ||
| private double actual; |
Contributor
There was a problem hiding this comment.
цю змінну нема сенсу виносити на рівень класу, вона для усіх методів повинна відрізнятись
| @Test | ||
| void calculate_illegalOperation_isNotOk() { | ||
| assertThrows(IllegalOperationException.class, () -> { | ||
| count.calculate(0, 2, '%'); |
Contributor
There was a problem hiding this comment.
Suggested change
| count.calculate(0, 2, '%'); | |
| count.calculate(0, 2, invalidOperation); | |
для читаймості краще цей чар оголосити змінною в методі
MaliukDaria
approved these changes
Oct 25, 2021
|
|
||
| public class Calculator implements Calculation { | ||
| @Override | ||
| public double calculate(double number1, double number2, char operation) { |
There was a problem hiding this comment.
плохая практика использовать числа в названии переменных и аргументов
| case '^': | ||
| return Math.pow(number1, number2); | ||
| default: | ||
| throw new IllegalOperationException("Illegal operator"); |
There was a problem hiding this comment.
Suggested change
| throw new IllegalOperationException("Illegal operator"); | |
| throw new IllegalOperationException("Illegal operator " + operation); | |
лучше делать сообщение ошибок как можно более информативными
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.