Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 76 additions & 8 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,116 @@
package core.basesyntax;

import java.util.NoSuchElementException;

public class ArrayList<T> implements List<T> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line after opening brace - checklist says 'Don't begin class or method implementation with an empty line'

private static final int DEFAULT_CAPACITY = 10;

private Object[] elements;

private int size;

public ArrayList() {
elements = new Object[DEFAULT_CAPACITY];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line after this line - methods should not begin with an empty line

@Override
public void add(T value) {

growIfFull();
elements[size] = value;
size++;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line

@Override
public void add(T value, int index) {
checkIndexForAdd(index);
growIfFull();

System.arraycopy(elements, index, elements, index + 1, size - index);

elements[index] = value;
size++;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
public void addAll(List<T> list) {

for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
@SuppressWarnings("unchecked")
public T get(int index) {
return null;
checkIndex(index);
return (T) elements[index];
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
public void set(T value, int index) {

checkIndex(index);
elements[index] = value;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
@SuppressWarnings("unchecked")
public T remove(int index) {
return null;
checkIndex(index);
final T removed = (T) elements[index];
System.arraycopy(elements, index + 1, elements, index, size - index - 1);

elements[size - 1] = null;
size--;
return removed;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
@SuppressWarnings("unchecked")
public T remove(T element) {
return null;
for (int i = 0; i < size; i++) {
T current = (T) elements[i];

if (current == element
|| current != null && current.equals(element)) {
return remove(i);
}
}
throw new NoSuchElementException("Element not found: " + element);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
public int size() {
return 0;
return size;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


@Override
public boolean isEmpty() {
return false;
return size == 0;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line

}

private void growIfFull() {
if (size == elements.length) {
int newCapacity = elements.length + elements.length / 2;
Object[] newElements = new Object[newCapacity];

System.arraycopy(elements, 0, newElements, 0, size);
elements = newElements;
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


private void checkIndex(int index) {
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException(
"Index: " + index + ", Size: " + size
);
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line


private void checkIndexForAdd(int index) {
if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException(
"Index: " + index + ", Size: " + size
);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line before this method - methods should not begin with an empty line

}
}
Loading