updated class ArrayList#1792
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your ArrayList implementation is well-structured and meets all functional requirements. The core logic correctly implements a 1.5x growth factor using System.arraycopy(), maintains proper exception handling with informative messages, and follows good design principles with separate methods for resizing and index validation. All required methods are properly implemented with the default capacity set to 10. Regarding the empty line formatting issues mentioned in the file comments - these are considered minor style concerns and won't prevent your code from passing. The checklist item about not beginning class or method implementations with empty lines relates to formatting preferences that are typically handled by linters or automated style checks. Your functional implementation is correct and complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| import java.util.NoSuchElementException; | ||
|
|
||
| public class ArrayList<T> implements List<T> { | ||
|
|
There was a problem hiding this comment.
Remove empty line after opening brace - checklist says 'Don't begin class or method implementation with an empty line'
| public ArrayList() { | ||
| elements = new Object[DEFAULT_CAPACITY]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove empty line after this line - methods should not begin with an empty line
| elements[size] = value; | ||
| size++; | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
|
|
||
| elements[index] = value; | ||
| size++; | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| for (int i = 0; i < list.size(); i++) { | ||
| add(list.get(i)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| public int size() { | ||
| return 0; | ||
| return size; | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| @Override | ||
| public boolean isEmpty() { | ||
| return false; | ||
| return size == 0; |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| System.arraycopy(elements, 0, newElements, 0, size); | ||
| elements = newElements; | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| "Index: " + index + ", Size: " + size | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
| throw new ArrayListIndexOutOfBoundsException( | ||
| "Index: " + index + ", Size: " + size | ||
| ); | ||
| } |
There was a problem hiding this comment.
Remove empty line before this method - methods should not begin with an empty line
2 participants
No description provided.