Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
41 changes: 39 additions & 2 deletions src/transformStateWithClones.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,44 @@
* @return {Object[]}
*/
function transformStateWithClones(state, actions) {
// write code here
}
let currentState = state;
const history = [];

for (const action of actions) {
let nextState;

switch (action.type) {
case 'clear':
nextState = {};
break;

case 'addProperties':
nextState = { ...currentState };

if (typeof action.extraData === 'object' && action.extraData !== null) {
Object.assign(nextState, action.extraData);
}
break;
case 'removeProperties':
nextState = { ...currentState };

if (Array.isArray(action.keysToRemove)) {
for (const key of action.keysToRemove) {
delete nextState[key];
}
}
break;

default:
// ação desconhecida → apenas clona o estado
nextState = { ...currentState };
break;
}
Comment on lines +16 to +42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switch statement repeats the state cloning logic (nextState = { ...currentState };) in the addProperties, removeProperties, and default cases. This goes against the "Don't Repeat Yourself" principle mentioned in checklist item #4.

A better approach would be to perform the common action (cloning the state) once, before the switch. The switch can then handle only the unique logic for each action type.


history.push(nextState);
currentState = nextState;
}

return history;
}
module.exports = transformStateWithClones;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module.exports statement is a duplicate of the one on line 50 and can be removed.