-
Notifications
You must be signed in to change notification settings - Fork 4.8k
exercise finished #5240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
exercise finished #5240
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Your solution is functionally correct and handles all the state transformations well, which is great! However, this requires a change because the implementation uses if statements to handle the different action types. A specific requirement for this task is to use a switch statement for this kind of conditional logic [CHECKLIST ITEM #2]. Please refactor your code to use a switch on action.type. This change will also make it straightforward to add a default case to handle unknown actions, which is another requirement [CHECKLIST ITEM #3].
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (action.type === 'clear') { | ||
| nextState = {}; | ||
| } else { | ||
| nextState = { ...currentState }; | ||
| } | ||
|
|
||
| if ( | ||
| action.type === 'removeProperties' && | ||
| Array.isArray(action.keysToRemove) | ||
| ) { | ||
| for (const key of action.keysToRemove) { | ||
| delete nextState[key]; | ||
| } | ||
| } | ||
|
|
||
| if ( | ||
| action.type === 'addProperties' && | ||
| typeof action.extraData === 'object' && | ||
| action.extraData !== null | ||
| ) { | ||
| Object.assign(nextState, action.extraData); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.