Remove imp module import.#225
Closed
quadrater wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for this, but I'm going to close this in favor of a separate PR #226 which eliminates the import machinery entirely in favor of a more direct attribute spec. The new release should be coming as soon as I settle all the environment and publishing workflow updates that need to happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer python installations fail installation of jams due to depreciated module imp. This PR updates the to the newer syntax with importlib.
Clean installation tested on all supported versions of python. Slightly simpler than #224 and related to ticket #223.
for v in 3.9 3.10 3.11 3.12 3.13 ; do uv venv --python $v ;. .venv/bin/activate; uv pip install git+https://github.com/quadrater/jams; deactivate; done
Using CPython 3.9.23
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
Resolved 17 packages in 189ms
Installed 17 packages in 97ms
Using CPython 3.10.17 interpreter at: /usr/bin/python3.10
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
Resolved 17 packages in 137ms
Installed 17 packages in 114ms
Using CPython 3.11.12 interpreter at: /usr/bin/python3.11
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
Resolved 17 packages in 84ms
Installed 17 packages in 118ms
Using CPython 3.12.3 interpreter at: /usr/bin/python3.12
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
Resolved 17 packages in 85ms
Installed 17 packages in 94ms
Using CPython 3.13.4
Creating virtual environment at: .venv
Activate with: source .venv/bin/activate
Resolved 16 packages in 81ms
Installed 16 packages in 98ms