Fix installations for Python 3.12#164
Merged
Merged
Conversation
Contributor
Author
|
Blocked by marl/jams#225 / marl/jams#224 / marl/jams#223 |
For Python 3.12 support (imp has been removed)
Owner
|
LGTM. Before merging: why are several tests not passing? |
Contributor
Author
|
There were upstream issues from JAMS with Python 3.12 changes ( Though there's some additional SciPy errors to fix:
|
Contributor
Author
|
Looks good now! Tests passing on Python 3.8 to 3.12. 🎉 |
Owner
|
Amazing, I'll merge once I'm back with a computer (taking a few days off) :)
Thanks so much!❤️
…On Sun, Jun 29, 2025, 14:57 Carl Thomé ***@***.***> wrote:
*carlthome* left a comment (urinieto/msaf#164)
<#164 (comment)>
Looks good now! Tests passing on Python 3.8 to 3.12. 🎉
—
Reply to this email directly, view it on GitHub
<#164 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4GFMI34DORD5D3OZ5NHL33GBHNFAVCNFSM6AAAAAB7AP43SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJXGEYDQNJTGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
good!! |
Owner
|
Merged, thanks so much, @carlthome ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to replace imp with importlib in setup.py for Python 3.12 support (imp has been removed now).