MLE-24747 Bumping version #238
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR removes Prometheus monitoring functionality from the test environment while bumping the version from 1.11.0 to 2.0.0. The major version bump suggests a breaking change related to the removal of Prometheus integration.
- Removed Prometheus service and all related configuration from Docker Compose
- Updated version from 1.11.0 to 2.0.0
- Deleted Prometheus alertmanager configuration file
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-app/docker-compose.yml | Removed Prometheus service definition and all Prometheus-related environment variables and dependencies |
| gradle.properties | Bumped version from 1.11.0 to 2.0.0 |
| docker/prometheus/config/alertmanager-generated.yml | Completely removed the alertmanager configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| alertmanager: | ||
| image: confluentinc/cp-enterprise-alertmanager:2.2.0 | ||
| hostname: cp-enterprise-alertmanager | ||
| container_name: alertmanager | ||
| depends_on: | ||
| - prometheus | ||
| volumes: | ||
| - ../docker/prometheus/config:/mnt/config | ||
| ports: | ||
| - "9093:9093" |
There was a problem hiding this comment.
The alertmanager service is still present but its configuration file has been removed. Consider either removing the alertmanager service entirely or providing a new configuration file, as it will likely fail to start without proper configuration.
| CONTROL_CENTER_PROMETHEUS_URL: http://prometheus:9090 | ||
| CONTROL_CENTER_PROMETHEUS_RULES_FILE: /mnt/config/trigger_rules-generated.yml | ||
| CONTROL_CENTER_ALERTMANAGER_URL: http://alertmanager:9093 | ||
| CONTROL_CENTER_ALERTMANAGER_CONFIG_FILE: /mnt/config/alertmanager-generated.yml |
There was a problem hiding this comment.
Control Center is configured to use alertmanager configuration file '/mnt/config/alertmanager-generated.yml' which has been deleted. This will cause Control Center to fail when trying to access alertmanager functionality.
| CONTROL_CENTER_ALERTMANAGER_CONFIG_FILE: /mnt/config/alertmanager-generated.yml |
rjrudin
force-pushed
the
feature/bump
branch
2 times, most recently
from
dfc8ab6 to
a62e053
Compare
rjrudin
changed the title
2 participants
No description provided.