Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 17, 2025

Almost no code changes! Just 1 for Polaris reasons.

Update Gradle to 8.14.3
Upgrade Data Hub to 6.2.1
Upgrade to MarkLogic 12
Require Java 17
MLE-24489 - Multiple upgrades to prep for Kafka 4
This allows for test-app to be a subproject, allowing a developer to run `mlDeploy` from the root directory.
MLE-12345 Fixing weird plugin classpath issue
MLE-24489 - Moving the docker file
Switch Jenkinsfile to use the Docker image instead of the RPM.
MLE-24529 - Upgrade to the latest MarkLogic 12 Docker image.
Also updating the copyright check configuration.
MLE-24538 - Changing the MarkLogic 12 Docker image again.
Splitting into 2 docker-compose files to facilitate automated and manual testing.
MLE-24538 - Trying to figure out the intermittent Jenkins failures.
Force upgrade to Spring 6
New files for the new CP stack and updated .gitignore for those files.
org.eclipse.jetty:jetty-http:12.1.1
io.netty:netty-all:4.2.6.Final
Fixed some Gradle warnings as well.
Want to see these tests pass before we release ml-gradle 6.1.0. Also fixed one Sonar issue - there are 71 others that I'll handle in separate PRs.
Copilot confirms that Kafka is not as picky about the version of Jackson used by connectors.
This is currently failing due to out-of-date GH actions.
This removes ml-gradle from the list of direct dependencies, as it's not really - it's only marklogic-data-hub that is a direct dependency.
Not mentioning Confluent Platform versions anymore, so we don't have to be in the business of syncing with those. We just want to mention Kafka versions.
@rjrudin rjrudin requested a review from BillFarber as a code owner October 17, 2025 16:13
@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 16:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the develop branch into master for the 2.0.0 release of the MarkLogic Kafka connector. The release includes infrastructure updates, configuration changes, and minimal code modifications.

Key changes:

  • Upgraded to Gradle 8.14.3 and Confluent Platform 8.0.0 with enhanced monitoring capabilities
  • Updated system requirements to mandate Kafka 4.0+ and Java 17+ for version 2.0.0
  • Refactored logger variable name from logger to staticLogger to comply with Polaris requirements

Reviewed Changes

Copilot reviewed 22 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle/wrapper/gradle-wrapper.properties Updated Gradle wrapper to version 8.14.3
gradle.properties Bumped project version to 2.0.0
src/main/java/com/marklogic/kafka/connect/source/XmlPlanInvoker.java Renamed static logger variable to comply with code standards
docs/system-requirements.md Updated requirements to specify Kafka 4.0+ and Java 17+ for version 2.0.0
test-app/docker-compose.yml Upgraded Confluent Platform to 8.0.0 with Prometheus/Alertmanager integration
test-app/build.gradle Updated ml-data-hub to 6.2.1 and modernized task definitions
CONTRIBUTING.md Reorganized documentation to separate automated and manual testing workflows
NOTICE.txt Updated copyright and third-party dependency versions
Jenkinsfile Migrated CI pipeline to Java 17 and added ML12 testing
.github/workflows/*.yaml Updated GitHub Actions and added copyright validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

[Sonar Gradle plugin docs](https://docs.sonarqube.org/latest/analyzing-source-code/scanners/sonarscanner-for-gradle/).
### MarkLogic Preparation
Please ensure you've followed the instructions for "MarkLogic Preparation" in the "Configuring Local Automated Testing"
sectuib above for deploying a Data Hub test application.
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'sectuib' to 'section'.

Suggested change
sectuib above for deploying a Data Hub test application.
section above for deploying a Data Hub test application.

Copilot uses AI. Check for mistakes.

@rjrudin rjrudin merged commit 32948cd into master Oct 17, 2025
2 checks passed
@rjrudin rjrudin deleted the develop branch October 17, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants