Skip to content

GH#34303: feat(site-inventory): record purpose ownership and DNS accounts - #34305

Merged
vladimirdulov merged 1 commit into
mainfrom
feature/auto-20261011-004523-gh34303
Oct 11, 2026
Merged

vladimirdulov merged 1 commit into
mainfrom
feature/auto-20261011-004523-gh34303

Conversation

@alex-solovyev

@alex-solovyev alex-solovyev commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Resolves #34303.

  • Add optional purpose and ownership records for sites and multisite children, preserving child alias matching from GH#34301: fix(site-context): match multisite children by aliases #34304.
  • Resolve effective DNS account references into a restricted metadata projection and validate ownership types, boolean confirmation flags and DNS references on parents and children.
  • Update the version-1 template and .agents/reference/site-operations.md with precedence and inferred-ownership guidance.

Scope and reference pattern

Only .agents/scripts/site-context-helper.sh, .agents/configs/site-inventory.json.txt, and .agents/reference/site-operations.md change. DNS account resolution follows the existing hosting account pattern; child objects override parent records rather than merging ownership or DNS fields. The optional list subcommand is deferred.

Runtime Testing

Risk: medium. Verification: runtime-verified at commit 93f771b1d334c6a6de61b9dd654cebad9b51d8a5.

  • 45 scoped scratch-inventory runtime checks pass using jq 1.8.2: template validation, site and child hostname/alias lookup, all seven ownership types, invalid ownership/confirmation/DNS-reference rejection on both parents and children, child override and inheritance, and DNS metadata projection.
  • Legacy inventory validation passes, with exact JSON equality against the default-branch helper for lookup/readiness/discover across site keys, hostnames, and parent/child aliases.
  • shellcheck .agents/scripts/site-context-helper.sh, bash -n .agents/scripts/site-context-helper.sh, and git diff --check pass.
  • The existing pre-push gate runs bun run typecheck and passes.

No provider requests, secret values, new test infrastructure, or schema version change. The scratch verification script is temporary and is not part of the repository diff.


aidevops.sh v3.39.0 plugin for OpenCode v1.18.34 with gpt-6.1-sol spent 4m and 65,397 tokens on this as a headless worker.

@alex-solovyev alex-solovyev added the origin:worker Created by headless/pulse worker session label Oct 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

🚫 Excluded labels (none allowed) (1)
  • no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: marcusquinn/aidevops/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cd2c9450-5685-4df4-a9fa-966dab357e98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Markdown Lint (changed-line scoped)

No new violations in changed lines (0 pre-existing in touched files — ignored).

Metric Base (42d0f18) Head (93f771b)
Total in touched files — 0
New (in changed lines) — 0

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@alex-solovyev

alex-solovyev commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator Author

Completion Summary

  • What: Add optional site/child purpose and ownership, reusable DNS accounts and safe account metadata resolution, plus validation and documentation.
  • Issue: site inventory: record each site's purpose, ownership and DNS account #34303
  • Files changed: .agents/configs/site-inventory.json.txt, .agents/reference/site-operations.md, .agents/scripts/site-context-helper.sh
  • Testing: runtime-verified at 93f771b1d334c6a6de61b9dd654cebad9b51d8a5; 45 scoped scratch-inventory checks pass, including site/child invalid metadata rejection, child precedence, alias matching and exact legacy output equality. ShellCheck, Bash syntax, diff whitespace and pre-push typecheck pass.
  • Key decisions: Keep schema version 1 and legacy output unchanged when new fields are absent; child ownership/DNS objects replace rather than merge parent objects. DNS account output projects only the four authorized metadata fields. Preserve GH#34301: fix(site-context): match multisite children by aliases #34304 child-alias matching. Defer the optional list subcommand.

aidevops.sh v3.39.0 plugin for OpenCode v1.18.34 with gpt-6.1-sol spent 4m and 65,397 tokens on this as a headless worker.


Merged via PR #34305 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

@alex-solovyev
alex-solovyev marked this pull request as ready for review October 11, 2026 00:49
@github-actions

Copy link
Copy Markdown
Contributor

Qlty Smell Regression Gate

✅ No change — smell count unchanged.

Metric Base (42d0f18) Head (93f771b) Delta
Total smells 65 65 +0

@github-actions

Copy link
Copy Markdown
Contributor

Shell Function Complexity Regression Gate

✅ No regression — no new function(s) >100 lines.

Metric Base (42d0f18) Head (93f771b)
Total function(s) >100 lines 0 0

@github-actions

Copy link
Copy Markdown
Contributor

Bash 3.2 Compatibility Regression Gate

✅ No regression — no new bash 3.2-incompatible construct(s).

Metric Base (42d0f18) Head (93f771b)
Total bash 3.2-incompatible construct(s) 0 0

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Sun Oct 11 00:50:18 UTC 2026: Code review monitoring started
Sun Oct 11 00:50:18 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1
Sun Oct 11 00:52:51 UTC 2026: Codacy analysis completed - issues found (exit 2)

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 1
  • VULNERABILITIES: 0

Generated on: Sun Oct 11 00:52:51 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@github-actions

Copy link
Copy Markdown
Contributor

Shell Nesting Depth Regression Gate

✅ No regression — no new file(s) with nesting depth >8.

Metric Base (42d0f18) Head (93f771b)
Total file(s) with nesting depth >8 0 0

@github-actions

Copy link
Copy Markdown
Contributor

File Size Regression Gate

✅ No regression — no new non-README Markdown file(s) >1000 lines at root / >500 elsewhere.

Metric Base (42d0f18) Head (93f771b)
Total non-README Markdown file(s) >1000 lines at root / >500 elsewhere 0 0

@vladimirdulov vladimirdulov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by pulse runner @vladimirdulov — author @alex-solovyev confirmed collaborator, pre-merge gates passed.


aidevops.sh v3.39.0 automated scan.

@vladimirdulov
vladimirdulov merged commit fa82ab9 into main Oct 11, 2026
78 of 81 checks passed
@vladimirdulov
vladimirdulov deleted the feature/auto-20261011-004523-gh34303 branch October 11, 2026 00:58
@github-actions github-actions Bot added the status:done Task is complete label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Created by headless/pulse worker session status:done Task is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site inventory: record each site's purpose, ownership and DNS account

2 participants